openbsc.git branch neels/gtphub updated. 0.15.0-36-gc009004

gitosis at gitosis at
Wed Nov 11 18:38:12 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, neels/gtphub has been updated
       via  c009004dfbb12552bcf1d258279f14574fc5b4c1 (commit)
       via  29ccadfbeedb8e8988b226710d3c0a1c8b92134a (commit)
       via  9063a251d6911352288176086696259f690d8842 (commit)
       via  245dd4247303e1956e3383ee34f162f601b301f1 (commit)
       via  634b36c1082720e6efcac50c4ba4874e5fecc5b1 (commit)
      from  c25dae97d4f4857e1261b860ff81c9aa31ceaca8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit c009004dfbb12552bcf1d258279f14574fc5b4c1
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Nov 11 19:37:47 2015 +0100

    fix resolve ggsn retval

commit 29ccadfbeedb8e8988b226710d3c0a1c8b92134a
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Nov 11 19:26:55 2015 +0100


commit 9063a251d6911352288176086696259f690d8842
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Nov 11 19:26:09 2015 +0100

    gtphub: don't always try to do GGSN resolution.
    If a GGSN is already known from unmapping, don't invoke a host resolution.
    In a live working environment, it wouldn't hurt, because the lookups would
    mostly return from the cache. But in a testing environment without a name
    server, it barfs on every packet.

commit 245dd4247303e1956e3383ee34f162f601b301f1
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Nov 11 17:27:01 2015 +0100

    gtphub: fix numerous segfaults, and other stupidities.
    Initialize llist_heads to empty (2 were missing). Move those for struct gtphub
    instances to gtphub_zero() (one moved, one added).
    In from_[gs]gsns_read_cb(), use a return type that can actually reflect
    negative return values.
    resolved_addr.buf: no need to take the address of a byte array var
    Pass the proper user data address to sgsn_ares_query(), not the address of
    the pointer holding the user data address.
    Initialize ggsn_lookup->expiry_entry (was missing). Publish the function for that
    in gtphub.h so gtphub_ext.c can use it.

commit 634b36c1082720e6efcac50c4ba4874e5fecc5b1
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Wed Nov 11 17:20:42 2015 +0100

    gtphub: Add logging for ares queries.
    Looking for a segfault, I added a lot of logging. This may be useful for
    live testing ares, leaving it in there for now.
    Note: I still want to clean up the logging concerning log levels etc. once
    we're out of alpha.


Summary of changes:
 openbsc/include/openbsc/gtphub.h   |  3 ++
 openbsc/src/gprs/       |  2 +-
 openbsc/src/gprs/gtphub.c          | 56 ++++++++++++--------------------------
 openbsc/src/gprs/gtphub_ext.c      | 35 ++++++++++++++++--------
 openbsc/tests/gtphub/gtphub_test.c | 21 ++++++++++++++
 5 files changed, 66 insertions(+), 51 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list