libosmocore.git branch master updated. 0.8.0-87-gd7b0577

gitosis at gitosis at
Mon Nov 2 14:58:49 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  d7b0577d7d30139491b5cfeffb467440f9e88818 (commit)
       via  8f0374f7521376bdb721e821047e8a6a4a727283 (commit)
       via  7921975989a1844546669a77ecdc9160fdef2282 (commit)
       via  837e940627cd8dc469e65980b3b48c9539a55440 (commit)
       via  79125ecf7d54b04cc56818b6dd99813d0a4daf89 (commit)
       via  bc9d9aced8c174bbb5fc265ec746621d31344be0 (commit)
       via  16fe8dab7c1fede87f6bdbfbbcbf19f64d60648a (commit)
       via  34eec7da8dd91c2e812863601ca5f787d6589ecb (commit)
       via  fc9533d6c4bde795dc0e18f02f91f54ab92888a2 (commit)
       via  bc4f7ae512b32fa4b569dfc5242d0b7a5da3f81b (commit)
       via  490b38f57a24726f3e3493fc3500cda526c5d0aa (commit)
       via  ed197fd4f923512fca5b93b90c2132845896fa59 (commit)
       via  4aa11770622ae9009074d68cc8c340821b19adf3 (commit)
       via  d01acfcc75a6c5798a95a8ccca9be18eba65a0bf (commit)
       via  c8f47b600f8e2ad21266d4c27e960e477e5fe35c (commit)
       via  80db4ec3875b0de7f06de769881d6c5d4b713f2d (commit)
       via  c27671c10935ee384d03a87170c3f31ab435da07 (commit)
       via  b1dbfb4c4179a62cd4b761ebdc7a3c2de5bdc0d9 (commit)
       via  adc900e0e38373193c8451c0310fe742d62c2c8e (commit)
       via  95bf828003b065f00a78144296072a9730cbf7bc (commit)
       via  45513e6040195f5494d40a2750de4dac7037593f (commit)
       via  7211fe157e1107d4a9c04a0ecf494a7b9633c400 (commit)
       via  aec583f68786f91c3f0d76a8f8706c85aaca07a8 (commit)
       via  e5b0fe2e3c84dd0de7021d65d416356612db4260 (commit)
       via  c6a7108828bf98ebcaf31d24bd8d789afdd4da94 (commit)
       via  423c1e5a4fc7ad2cd5e95e852b778c7e2c892bc1 (commit)
       via  b27b352e937dd0760da1e7fb05f9207be05702b8 (commit)
       via  0a1400fc8311268d0a66bb20e0620e546e8d11c8 (commit)
       via  738d9e22108a8e472458fad42509fd8d96994d6c (commit)
       via  9732cb4a92a883c7e9f7dcd928b6e22976a797ca (commit)
      from  c84851bccc2e5e60536afa474a5f13134a3b79c9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit d7b0577d7d30139491b5cfeffb467440f9e88818
Merge: c84851b 8f0374f
Author: Holger Hans Peter Freyther <holger at>
Date:   Mon Nov 2 15:57:34 2015 +0100

    Merge branch 'jerlbeck/wip/stats'
    * This adds a new counter type (to measure time or delay)
    * A statsd reporting backend. This can be fed into graphite
    or similar tools.
    * A periodic log backend for performance values

commit 8f0374f7521376bdb721e821047e8a6a4a727283
Author: Holger Hans Peter Freyther <holger at>
Date:   Mon Nov 2 15:53:09 2015 +0100

    stats: Fix handling of the no mtu command
    For the atoi we need to pass the val as a string. This means
    we need to write "0" which then gets parsed to 0.
    [src/vty/stats_vty.c:90]: (error) Possible null pointer dereference: val

commit 7921975989a1844546669a77ecdc9160fdef2282
Author: Holger Hans Peter Freyther <holger at>
Date:   Mon Nov 2 15:50:32 2015 +0100

    stats: Do not assign the wrong addresss
    we need to put the default value into inaddr and not put a
    32bit value into the addr pointer.
    Spotted by cppcheck:
    [src/stats.c:231]: (error) Uninitialized variable: inaddr

commit 837e940627cd8dc469e65980b3b48c9539a55440
Author: Holger Hans Peter Freyther <holger at>
Date:   Mon Nov 2 15:44:26 2015 +0100

    stats: Remove warnings about never read variables
    Nothing is being done with these return values. Remove them
    for now and update the TODO entry that is present at two of
    the three places.
    stats.c: In function ‘rate_ctr_handler’:
    stats.c:570:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
      int rc;
    stats.c: In function ‘osmo_stat_item_handler’:
    stats.c:617:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
      int rc;
    stats.c: In function ‘handle_counter’:
    stats.c:651:6: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable]
      int rc;

commit 79125ecf7d54b04cc56818b6dd99813d0a4daf89
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Nov 2 15:17:50 2015 +0100

    log: Add new DLSTATS log level
    This log level is used by the stats subsystem log reporter to report
    statistics to level INFO. Note that the default level of DLSTATS is
    Sponsored-by: On-Waves ehf

commit bc9d9aced8c174bbb5fc265ec746621d31344be0
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Nov 2 14:49:35 2015 +0100

    stats: Limit reporting by class id
    This commit adds class_id fields to the rate_ctr and stat_item group
    descriptions. The stats reporter code is extended to only process
    groups whose class_id does not exceed a per reporter max_class level.
    If the class_id is not set, the code assumes 'global' for groups with
    idx == 0 and 'subscriber' otherwise.
    The following vty command is added to config-stats:
      level (global|peer|subscriber)  Set the maximum group level
    Sponsored-by: On-Waves ehf

commit 16fe8dab7c1fede87f6bdbfbbcbf19f64d60648a
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Nov 2 11:30:01 2015 +0100

    stats: Report group indices as unsigned int
    Currently the unsigned group index value is silently being cast to
    (signed) int in the log and statsd reporter code. If the resulting
    value is negative (which can happen for instance with MMCTX
    counters), the index is assumed to be unset.
    This commit changes the affected types to unsigned. The index value 0
    is then the only value indicating an unset group.
    Sponsored-by: On-Waves ehf

commit 34eec7da8dd91c2e812863601ca5f787d6589ecb
Author: Jacob Erlbeck <jerlbeck at>
Date:   Mon Nov 2 10:50:50 2015 +0100

    vty: Add reserved nodes to enum node_type
    Currently every time a node is added to enum node_type, this
    constitutes an ABI change, since _LAST_OSMOVTY_NODE will get
    incremented accordingly. In this case, every project that adds new
    node type based on that value will have to be recompiled.
    This commit adds 4 spare node type values, which can be replaced
    one-by-one by new real types until they are exhausted to avoid
    this kind of ABI change.
    Sponsored-by: On-Waves ehf

commit fc9533d6c4bde795dc0e18f02f91f54ab92888a2
Author: Jacob Erlbeck <jerlbeck at>
Date:   Thu Oct 29 00:55:58 2015 +0100

    stats: Add osmo_ name prefix to identifiers
    Since the the stat_item and stats functions and data types are meant
    to be exported, they get an osmo_ prefix.
    Sponsored-by: On-Waves ehf
    [hfreyther: Prepended the enum values too. This was requested by


Summary of changes:
 .gitignore                                         |   1 +
 TODO-RELEASE                                       |   2 +
 include/                                |   3 +
 include/osmocom/core/logging.h                     |   3 +-
 include/osmocom/core/rate_ctr.h                    |  21 +
 include/osmocom/core/stat_item.h                   | 130 ++++
 include/osmocom/core/statistics.h                  |   8 +-
 include/osmocom/core/stats.h                       | 110 ++++
 include/osmocom/gprs/gprs_ns.h                     |   2 +
 include/osmocom/vty/command.h                      |  10 +
 include/osmocom/vty/misc.h                         |   8 +-
 include/osmocom/vty/stats.h                        |   3 +
 src/                                    |   2 +-
 src/gb/gprs_bssgp.c                                |   2 +
 src/gb/gprs_ns.c                                   |  38 ++
 src/gb/gprs_ns_vty.c                               |   4 +-
 src/logging.c                                      |   5 +
 src/rate_ctr.c                                     |  41 ++
 src/stat_item.c                                    | 268 ++++++++
 src/statistics.c                                   |   8 +
 src/stats.c                                        | 696 +++++++++++++++++++++
 src/vty/                                |   2 +-
 src/vty/stats_vty.c                                | 430 +++++++++++++
 src/vty/utils.c                                    | 125 +++-
 tests/                                  |  15 +-
 tests/stats/stats_test.c                           | 213 +++++++
 .../logging_test.ok => stats/stats_test.ok}        |   0
 tests/                                 |   6 +
 tests/vty/vty_test.ok                              |   6 +-
 29 files changed, 2135 insertions(+), 27 deletions(-)
 create mode 100644 include/osmocom/core/stat_item.h
 create mode 100644 include/osmocom/core/stats.h
 create mode 100644 include/osmocom/vty/stats.h
 create mode 100644 src/stat_item.c
 create mode 100644 src/stats.c
 create mode 100644 src/vty/stats_vty.c
 create mode 100644 tests/stats/stats_test.c
 copy tests/{loggingrb/logging_test.ok => stats/stats_test.ok} (100%)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list