osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-439-gc299cee

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Wed May 27 11:37:17 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  20296a48676094a09c7928006e62e890c2e69e0f (commit)
  discards  87e6ed022df45b70d93c96581cc1c99b76a80718 (commit)
  discards  6e3311b641b51cb4cc790f2e488e45602724ce36 (commit)
  discards  7044acabf5ac371a4e80bb1fc81650b36187deaa (commit)
  discards  7e64d5f11482efb55766ea1696e799fde6b66b2b (commit)
  discards  95abc21ff352cff1c57453262b998e32b8ea7afd (commit)
  discards  50b6e02a859561d2044a5e6bc20af2f11f6ebaad (commit)
  discards  8a26db1dd366a540288cec634f6a02afc851fb3e (commit)
  discards  a12e11c98d30f075c7e2f33cc4400c34d446f541 (commit)
  discards  f0045d04d3cd03579005231b7dcbbac3cac3b83b (commit)
  discards  2ee112c2e134146c501601e0faf01014393bd7b7 (commit)
       via  c299cee15cabb2a8c2ad7eb54da182f2b73d3f16 (commit)
       via  aa9c1199e40d19c2f65dfcb6d3239483b2dbc2bf (commit)
       via  1c96d98d9c392f60e457d3dac310e5826489c50e (commit)
       via  d4b882dd013c6a2069995a7cb89eecde283d92e1 (commit)
       via  1c674ff4826c18741acf685c0073236e2f431fb6 (commit)
       via  0ef422fe0307183b6281aca77074827cb61f2024 (commit)
       via  24ebf9022f7d76b00771b32c9557a50106329ba3 (commit)
       via  69381940f40a2d42f75e060e79d63feed54ff609 (commit)
       via  9a2845d491b088cb9e1962ba6dc8af5a4e279401 (commit)
       via  0e50ce614569b9ae7bcc6e7becc4aeec46e8369d (commit)
       via  767193e20b4172dfb0e76ec63444115dc5ae8806 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (20296a48676094a09c7928006e62e890c2e69e0f)
            \
             N -- N -- N (c299cee15cabb2a8c2ad7eb54da182f2b73d3f16)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=c299cee15cabb2a8c2ad7eb54da182f2b73d3f16

commit c299cee15cabb2a8c2ad7eb54da182f2b73d3f16
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 18:02:51 2015 +0200

    tbf: Remove TimingAdvance storage
    
    Currently the TA storage stores up to 30 TLLI->TA mappings, if more
    entries are created the oldest one is dropped. In theory this can
    lead to missing TA information if many MS are present.
    
    This commit removes the TimingAdvance class completely, since the TA
    value is now stored in the GprsMs objects.
    
    Note that the GprsMs objects are currently not kept after the TBFs
    have detached from them, so the TA values are now kept for a shorter
    time than before.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=aa9c1199e40d19c2f65dfcb6d3239483b2dbc2bf

commit aa9c1199e40d19c2f65dfcb6d3239483b2dbc2bf
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 17:48:04 2015 +0200

    tbf: Store the timing advance (TA) value in the GprsMs object
    
    The TA value rather relates to an MS and not to a single TBF. So all
    TBFs share the same TA value. Currently the TA value is stored per
    TBF and eventually copied from an old TBF to a new one. It is in
    general only passed with an RACH request when the TLLI and thus the
    MS is not yet known.
    
    This commit adds a TA member to the GprsMs class and uses that one
    when the TBF is associated to an MS object. Since the TBF is not
    always associated with an MS object (after RACH or when it has been
    replaced by another TBF), the TA value is still stored in each TBF
    and that value is used as long as no MS object is being associated.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=1c96d98d9c392f60e457d3dac310e5826489c50e

commit 1c96d98d9c392f60e457d3dac310e5826489c50e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed May 27 13:03:15 2015 +0200

    tbf/test: Add tests for single and two phase access
    
    These tests cover the message exchange from receiving from the first
    RACH request to the first data block when establishing an uplink TBF.
    
    This will be used to check, whether TA and other values are passed to
    an MS object correctly.
    
    In addition, the RX RACH log message in rcv_rach is extended to
    contain the single block fn.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=d4b882dd013c6a2069995a7cb89eecde283d92e1

commit d4b882dd013c6a2069995a7cb89eecde283d92e1
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:47:55 2015 +0200

    tbf: Remove TBF chaining (m_new_tbf and m_old_tbf)
    
    Currently a new TBF is chained to an existing older one, either of
    the other direction (active or releasing) or of the same direction
    (releasing). This does not work properly work if and uplink and a
    downlink TBF are being established at the same time while an old TBF
    is being released. In that case, one of them is thrown away and the
    pending procedure is cancelled.
    
    The chaining is no longer necessary since the GprsMs objects have
    been introduced which keep track of the active TBFs.
    
    This commit removes the TBF members m_new_tbf and m_old_tbf and the
    related methods and code paths.
    
    Note that a new TBF can replace an older TBF entry of the same
    direction within an MS object when it is associated with an MS (e.g.
    by TLLI or because it is assigned via another, already associated
    TBF). In that case, the old TBF is no longer associated with an MS
    object.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=1c674ff4826c18741acf685c0073236e2f431fb6

commit 1c674ff4826c18741acf685c0073236e2f431fb6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:40:08 2015 +0200

    tbf/test: Attach TLLI and MS objects to TBFs
    
    Currently the DL TBF's TLLI are not set. This will have to change in
    the future, when the m_new_tbf chaining is replaced by the usage of MS
    object to group TBFs.
    
    This commit just calls update_ms() on newly created TBFs. This
    changes many of the lines written to stderr due to the TLLI change,
    but doesn't change other aspects or messages beside creating and
    destroying MS objects.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=0ef422fe0307183b6281aca77074827cb61f2024

commit 0ef422fe0307183b6281aca77074827cb61f2024
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:10:15 2015 +0200

    tbf: Remove IMSI handling from trigger_dl_ass
    
    Currently the BTS::trigger_dl_ass() method assigns the IMSI to the MS
    object. This should be (and is already) done earlier where the MS
    object is retrieved/created.
    
    This commit removes the corresponding code along with the 'imsi'
    parameter from trigger_dl_ass.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=24ebf9022f7d76b00771b32c9557a50106329ba3

commit 24ebf9022f7d76b00771b32c9557a50106329ba3
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:53 2015 +0200

    ms: Use the IMSI to retrieve the MS object
    
    This commit extends get_ms() to really compare the IMSI if it has
    been given. Note that the MS object list will be traversed only once
    and that the first entry with a matching TLLI or a matching IMSI will
    be returned. Thus there is no precedence.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=69381940f40a2d42f75e060e79d63feed54ff609

commit 69381940f40a2d42f75e060e79d63feed54ff609
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:16 2015 +0200

    tbf: Move IMSI to MS object
    
    Currently the IMSI is stored in the TBFs. Since it directly refers to
    an MS, it should rather be stored in an MS object.
    
    This patch move the m_imsi field from gprs_rlcmac_tbf to GprsMs,
    changes gprs_rlcmac_tbf::imsi() to get the IMSI from the associated
    MS object, and adds getter and setter to GprsMs. Note that the
    assign_imsi() method is now called set_imsi() for consistency within
    the GprsMs class.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=9a2845d491b088cb9e1962ba6dc8af5a4e279401

commit 9a2845d491b088cb9e1962ba6dc8af5a4e279401
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 12:06:58 2015 +0200

    tbf/test: Fix IMSI creation
    
    Currently the generated IMSI contains blanks due to a missing '0'
    flag in the corresponding snprintf statement. In addition, the buffer
    is effectively limited to 15 bytes which is shorter than the
    generated character sequence, such that the last character of the
    IMSI is removed.
    
    This patch fixes both issues. Since snprintf itself will add a
    terminating \0 character, the whole buffer can be passed to snprintf.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=0e50ce614569b9ae7bcc6e7becc4aeec46e8369d

commit 0e50ce614569b9ae7bcc6e7becc4aeec46e8369d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 16:58:22 2015 +0200

    tbf: Always call set_tlli/confirm_tlli in update_ms
    
    Currently the m_tlli member in GprsMs is set by the constructor,
    circumventing the TLLI confirmation mechanism.
    
    This commit replaces the get_or_create_ms() method by a create_ms()
    method which takes the TLLI and the direction (UL or DL) as
    parameters to select either set_tlli() or confirm_tlli(). The MS
    object is instantiated with TLLI = 0, and therefore GprsMs::tlli() is
    extended to return the DL TLLI if both of the other TLLI are not set.
    
    Note that create_ms() will not check whether an MS object with a
    matching TLLI is already stored in the list, so it should only be
    called after a corresponding get_ms() in general.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=767193e20b4172dfb0e76ec63444115dc5ae8806

commit 767193e20b4172dfb0e76ec63444115dc5ae8806
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed May 20 12:06:46 2015 +0200

    tbf: Remove the TLLI from the TBFs
    
    Currently the TLLI is stored in each TBF. Since each MS is now
    represented by a GprsMs object which takes care of TLLI updating,
    and each TBF that has been associated with an TLLI also contains a
    reference to a GprsMs object, per TBF TLLI handling is no longer
    needed. Keeping all TBF m_tlli members up to date is complex and
    doesn't currently work correctly in all circumstances.
    
    This commit removes m_tlli and related members from the TBF class and
    the tbf_by_tlli functions from the BTS class.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 src/bts.h | 1 -
 1 file changed, 1 deletion(-)


hooks/post-receive
-- 
UNNAMED PROJECT



More information about the osmocom-commitlog mailing list