osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-438-g35558a8

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Fri May 22 17:26:21 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  9786c3efe4ecf0c710e3681a2aff73bb87320ea6 (commit)
  discards  56d8c053acc482f2b972b68f91c605c215094645 (commit)
  discards  087629ea2bfd5942cd8f6ae79f55c571b30c0b8b (commit)
  discards  8e843883fb6b0ee8020c856f1220dcdb068d5272 (commit)
  discards  ce1ce40ad4d98d3b084ef1e37a72ba5dcb33f448 (commit)
       via  35558a89aa5d3f8eb8c805d2c8412f409e090b88 (commit)
       via  e4947f1bb86a251dce68cb695d9fca16adff6bf4 (commit)
       via  89cde650e249e9791455a3752caa5af2f2923ce8 (commit)
       via  7e64d5f11482efb55766ea1696e799fde6b66b2b (commit)
       via  95abc21ff352cff1c57453262b998e32b8ea7afd (commit)
       via  50b6e02a859561d2044a5e6bc20af2f11f6ebaad (commit)
       via  8a26db1dd366a540288cec634f6a02afc851fb3e (commit)
       via  a12e11c98d30f075c7e2f33cc4400c34d446f541 (commit)
       via  f0045d04d3cd03579005231b7dcbbac3cac3b83b (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (9786c3efe4ecf0c710e3681a2aff73bb87320ea6)
            \
             N -- N -- N (35558a89aa5d3f8eb8c805d2c8412f409e090b88)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/osmo-pcu/commit/?id=35558a89aa5d3f8eb8c805d2c8412f409e090b88

commit 35558a89aa5d3f8eb8c805d2c8412f409e090b88
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 18:02:51 2015 +0200

    tbf: Remove TimingAdvance storage (TODO)
    
    TODO:
      - the TA storage stored up to 30 TLLI->TA mappings, the MS objects
        are dropped quite often so that these need a longer life time
        (-> timer)
      - acc_delay/i16BurstTiming is not being used currently (separate
        commit)

http://cgit.osmocom.org/osmo-pcu/commit/?id=e4947f1bb86a251dce68cb695d9fca16adff6bf4

commit e4947f1bb86a251dce68cb695d9fca16adff6bf4
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 17:48:04 2015 +0200

    tbf: Store the TA value in the GprsMs (TODO)
    
    TODO:
      - commit message
      - add test cases for the corner cases:
        - is the TA maintained in the old TBF after "reuse"?
        - is the TA value passed when the MS gets assigned or is this
          always done (if TLLI in RLC/MAC -> TA in RLC/MAC)

http://cgit.osmocom.org/osmo-pcu/commit/?id=89cde650e249e9791455a3752caa5af2f2923ce8

commit 89cde650e249e9791455a3752caa5af2f2923ce8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:47:55 2015 +0200

    tbf: Remove TBF chaining by m_new_tbf (TODO)

http://cgit.osmocom.org/osmo-pcu/commit/?id=7e64d5f11482efb55766ea1696e799fde6b66b2b

commit 7e64d5f11482efb55766ea1696e799fde6b66b2b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri May 22 15:40:08 2015 +0200

    tbf/test: Attach TLLI and MS objects to TBFs
    
    Currently the DL TBF's TLLI are not set. This will have to change in
    the future, when the m_new_tbf chaining is replaced by the usage of MS
    object to group TBFs.
    
    This commit just calls update_ms() on newly created TBFs. This
    changes many of the lines written to stderr due to the TLLI change,
    but doesn't change other aspects or messages beside creating and
    destroying MS objects.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=95abc21ff352cff1c57453262b998e32b8ea7afd

commit 95abc21ff352cff1c57453262b998e32b8ea7afd
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:10:15 2015 +0200

    tbf: Remove IMSI handling from trigger_dl_ass
    
    Currently the BTS::trigger_dl_ass() method assigns the IMSI to the MS
    object. This should be (and is already) done earlier where the MS
    object is retrieved/created.
    
    This commit removes the corresponding code along with the 'imsi'
    parameter from trigger_dl_ass.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=50b6e02a859561d2044a5e6bc20af2f11f6ebaad

commit 50b6e02a859561d2044a5e6bc20af2f11f6ebaad
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:53 2015 +0200

    ms: Use the IMSI to retrieve the MS object
    
    This commit extends get_ms() to really compare the IMSI if it has
    been given. Note that the MS object list will be traversed only once
    and that the first entry with a matching TLLI or a matching IMSI will
    be returned. Thus there is no precedence.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=8a26db1dd366a540288cec634f6a02afc851fb3e

commit 8a26db1dd366a540288cec634f6a02afc851fb3e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 11:07:16 2015 +0200

    tbf: Move IMSI to MS object
    
    Currently the IMSI is stored in the TBFs. Since it directly refers to
    an MS, it should rather be stored in an MS object.
    
    This patch move the m_imsi field from gprs_rlcmac_tbf to GprsMs,
    changes gprs_rlcmac_tbf::imsi() to get the IMSI from the associated
    MS object, and adds getter and setter to GprsMs. Note that the
    assign_imsi() method is now called set_imsi() for consistency within
    the GprsMs class.
    
    Ticket: #1674
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=a12e11c98d30f075c7e2f33cc4400c34d446f541

commit a12e11c98d30f075c7e2f33cc4400c34d446f541
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 12:06:58 2015 +0200

    tbf/test: Fix IMSI creation
    
    Currently the generated IMSI contains blanks due to a missing '0'
    flag in the corresponding snprintf statement. In addition, the buffer
    is effectively limited to 15 bytes which is shorter than the
    generated character sequence, such that the last character of the
    IMSI is removed.
    
    This patch fixes both issues. Since snprintf itself will add a
    terminating \0 character, the whole buffer can be passed to snprintf.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/osmo-pcu/commit/?id=f0045d04d3cd03579005231b7dcbbac3cac3b83b

commit f0045d04d3cd03579005231b7dcbbac3cac3b83b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu May 21 16:58:22 2015 +0200

    tbf: Always call set_tlli/confirm_tlli in update_ms
    
    Currently the m_tlli member in GprsMs is set by the constructor,
    circumventing the TLLI confirmation mechanism.
    
    This commit replaces the get_or_create_ms() method by a create_ms()
    method which takes the TLLI and the direction (UL or DL) as
    parameters to select either set_tlli() or confirm_tlli(). The MS
    object is instantiated with TLLI = 0, and therefore GprsMs::tlli() is
    extended to return the DL TLLI if both of the other TLLI are not set.
    
    Note that create_ms() will not check whether an MS object with a
    matching TLLI is already stored in the list, so it should only be
    called after a corresponding get_ms() in general.
    
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 src/Makefile.am       |   2 -
 src/bts.cpp           |  44 +++++------
 src/bts.h             |   8 --
 src/encoding.cpp      |   4 +-
 src/gprs_ms.cpp       |  13 ++++
 src/gprs_ms.h         |   9 +++
 src/pcu_main.cpp      |   2 -
 src/ta.cpp            | 142 -----------------------------------
 src/ta.h              |  40 ----------
 src/tbf.cpp           |  91 +++++++----------------
 src/tbf.h             |  16 ++--
 src/tbf_dl.cpp        |  25 ++-----
 tests/tbf/TbfTest.cpp |  36 ++++++---
 tests/tbf/TbfTest.err | 200 +++++++++++++++++++++++---------------------------
 14 files changed, 198 insertions(+), 434 deletions(-)
 delete mode 100644 src/ta.cpp
 delete mode 100644 src/ta.h


hooks/post-receive
-- 
UNNAMED PROJECT



More information about the osmocom-commitlog mailing list