libosmocore.git branch master updated. 0.8.0-11-g267fd86

gitosis at gitosis at
Wed Mar 18 20:55:19 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  267fd86e7da57719577c50039129654bd396c651 (commit)
       via  6cce3d71537cd9dc077c407d865b8b8ffe1ee77f (commit)
       via  ca8dcb7bff9f9ed4cc52875a772246011e93cf31 (commit)
       via  36153dc61aa15f9c3084c2824c51356fc4babadb (commit)
       via  49ed9beed1a1f6df197defb295cf436b5eeb8933 (commit)
       via  b61b2ca1a0c63d99c642fe46b0bfef83eb092ba1 (commit)
      from  4dafdefa7adaea9ca10b357ed966fdcd183347df (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 267fd86e7da57719577c50039129654bd396c651
Author: Holger Hans Peter Freyther <holger at>
Date:   Wed Mar 18 21:52:38 2015 +0100

    libctrl: Include config.h so we can include netinet/tcp.h
    In e15ac060e7ae78d4c3569d7fc9071bcf49807e05 we tried to fix
    the nuttx build but we never included "netinet/tcp.h" after
    it and the compiler warned about the unused "on" parameter
    which we didn't notice because of the other warnings...
    Include config.h so we can see if there is a tcp.h and then
    include it.

commit 6cce3d71537cd9dc077c407d865b8b8ffe1ee77f
Author: Holger Hans Peter Freyther <holger at>
Date:   Wed Mar 18 21:35:56 2015 +0100

    msgfile: Fix warning on BSDs stdio
    msgfile.c:116:16: warning: implicit declaration of function 'getline' is invalid in C99
            while (getline(&line, &n, file) != -1) {

commit ca8dcb7bff9f9ed4cc52875a772246011e93cf31
Author: Holger Hans Peter Freyther <holger at>
Date:   Wed Mar 18 21:26:57 2015 +0100

    gsm0808: Remove duplicate initialization
    These types were compatible so simply remove one.
    gsm0808.c:323:37: warning: initializer overrides prior initialization  CC       gsm0480.lo
     of this subobject
            CC       abis_nm.lo
                    [GSM0808_IE_LSA_INFORMATION]            = { TLV_TYPE_TLV },
    gsm0808.c:316:36: note: previous initialization is here
                    [GSM0808_IE_LSA_INFORMATION]    = { TLV_TYPE_TLV },

commit 36153dc61aa15f9c3084c2824c51356fc4babadb
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Mar 17 10:21:17 2015 +0100

    bssgp: Handle BSSGP STATUS messages
    Currently incoming BSSGP STATUS messages are just logged and no other
    action is taken. This makes it impossible for higher layers to react
    to failures which are indicated by corresponding STATUS messages
    unless a timeout is triggered as a result of that failure later on.
    This commit adds a bssgp_rx_status() function and calls it on
    incoming STATUS messages. That function logs a message, increments the
    new BSSGP_CTR_STATUS counter if the bctx context exists and invokes
    an NM_STATUS status indication. The latter will allow the application
    to handle failures immediately. Since all STATUS messages should be
    handled, the function is already called in bssgp_rcvmsg and the
    message is no longer handled in (and will not reach) bssgp_rx_sign
    and bssgp_rx_ptp.
    Ticket: OW#1414
    Sponsored-by: On-Waves ehf

commit 49ed9beed1a1f6df197defb295cf436b5eeb8933
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Mar 17 10:21:16 2015 +0100

    bssgp: Don't reply with STATUS when receiving a PtP STATUS message
    Currently each incoming PtP BSSGP STATUS message is handled as 'not
    yet implemented' and a BSSGP STATUS message (cause
    BSSGP_CAUSE_PROTO_ERR_UNSPEC) is sent back to the peer. This will
    cause endless messages loops if both peers use this BSSGP stack
    implementation. This does not apply to signalling messages.
    This commit changes the implementation of bssgp_rx_ptp() to just do
    logging in this case.
    Sponsored-by: On-Waves ehf

commit b61b2ca1a0c63d99c642fe46b0bfef83eb092ba1
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Mar 17 10:21:15 2015 +0100

    logging: Implement subsecond resolution of extended timestamps
    Currently when using 'logging print extended-timestamp 1', the
    subsecond part (milliseconds) of the printed timestamp is always 0.
    This makes it difficult to correlate log entries with PCAP file
    entries if there are many of them per second.
    This patch changes _output in logging.c to use gettimeofday() instead
    of time() when extended timestamps are enabled and replaces the '000'
    by the milliseconds computed from tv_usec.
    Sponsored-by: On-Waves ehf


Summary of changes:
 include/osmocom/gprs/gprs_bssgp.h |  2 +
 src/ctrl/control_if.c             |  2 +
 src/gb/gprs_bssgp.c               | 78 +++++++++++++++++++++++++++++++--------
 src/gsm/gsm0808.c                 |  1 -
 src/logging.c                     | 11 ++++--
 src/msgfile.c                     |  2 +
 tests/gb/gprs_bssgp_test.c        | 35 ++++++++++++++++++
 tests/gb/gprs_bssgp_test.ok       |  4 ++
 8 files changed, 115 insertions(+), 20 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list