osmo-pcu.git branch jerlbeck/wip/ms-struct updated. 0.2-475-g9c2bc1f

gitosis at osmocom.org gitosis at osmocom.org
Fri Jun 12 15:08:08 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/ms-struct has been updated
  discards  60d611adcea23fd28a32913aba4ac3e6774fd630 (commit)
  discards  c0cd2ffc2b07340ffe4e788a61d31800b4866980 (commit)
  discards  939043b385ce0c0cbc2fc7c459e3f8f660a8260c (commit)
  discards  1e96f228d4ffd10a8b19f0c85b84d3fd5f5b7dd5 (commit)
       via  9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d (commit)
       via  2f7228b15fd8b55c6bc0c3e203aa19cb41497bf6 (commit)
       via  e61b652e1b9f184d8cf9584b068600e907df2347 (commit)
       via  53a32b8e95bed5cca800c98861458cbfed753104 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (60d611adcea23fd28a32913aba4ac3e6774fd630)
             N -- N -- N (9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 9c2bc1f28480b3487bbc34d6ba2779aff85bcc6d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 12 10:52:34 2015 +0200

    tbf: Reduce CS level if only a few LLC bytes are left (TODO)
    This is an experimental commit to reduce the coding scheme level if
    just a few bytes are left to send to the MS. This makes the
    transmission more robust and can improve throughput and latency if
    only a few small packages like TCP ACKs or ICMP PINGs are sent.
     - commit message
     - make threshold configurable (at least by a macro)
     - test case


commit 2f7228b15fd8b55c6bc0c3e203aa19cb41497bf6
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 12 14:06:09 2015 +0200

    tbf: Fix downlink packet loss
    When the MS is pinged with a longer interval, many packets get lost
    even if the GprsMs object is kept. If the interval is above the time
    where the DL TBF is in state FLOW (mainly influenced be the
    dl-tbf-idle-time command), an new TBF must be requested via AGCH for
    each ICMP PING message.
    Currently the LLC frame containing the PING is immediately stored
    in the TBF and gets lost, if TBF establishment fails for some reason.
    This commit moves all calls to put_frame() to schedule_next_frame(),
    where the data is moved from the LLC queue to the frame storage
    within the TBF object. This method is only called from within
    create_new_bsn() when the TBF is in the FLOW state and the frame is
    going to be encoded immediately.
    At all other places, where put_frame() has been called before, the
    LLC message is just appended to the LLC queue in the GprsMs object.
    This change effectively simplifies the related code parts, since
    date/len information and discard notifications is no longer needed
    Ticket: #1759
    Sponsored-by: On-Waves ehf


commit e61b652e1b9f184d8cf9584b068600e907df2347
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 12 13:41:00 2015 +0200

    tbf/test: Add test for DL LLC packet loss
    Currently LLC frames are lost or even reordered when the TBF has be
    established via the AGCH and the procedure fails for some reason.
    This test tries to reproduce this behaviour by throwing away the
    first TBF while calling the handle() method several times. The
    results of create_dl_acked_block() are checked against expected
    values (this is currently party disabled because the bug still
    Ticket: #1759
    Sponsored-by: On-Waves ehf


commit 53a32b8e95bed5cca800c98861458cbfed753104
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jun 12 16:01:56 2015 +0200

    ms: Store the NACK rate in the MS object
    Currently the NACK/unconfirmed ratio is already passed to the
    corresponding MS object, but the value is not being stored there.
    This commit adds a member and a getter method and include the values
    into the output of the 'show ms' command.
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/pcu_vty_functions.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


More information about the osmocom-commitlog mailing list