openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-905-gc58270a

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.

gitosis at osmocom.org gitosis at osmocom.org
Mon Jan 26 14:11:23 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, jerlbeck/wip/gprs-patching has been updated
  discards  5a8a00afe6f037a39b407bcacdcd35bd6b399f76 (commit)
  discards  3cf9a0dc5126198f9e94cb7104fb75b96afa4c6b (commit)
  discards  4c200652f7c54ff2e7e1708d93adf75be9f86712 (commit)
  discards  b6d0eaa0da84758fad88d213bb42fd00f1e030be (commit)
  discards  99ad4ec4a2261c3e1cda14c7fed6d7252ade7b96 (commit)
  discards  b10b16f9bdc4d916035313b68a7eeb6f55499c78 (commit)
  discards  7113c90e8476cc97271aeec7b2bb345474c95d64 (commit)
  discards  f5aebcac2c25d44a0a84a1ac71c7aedb23630e2d (commit)
  discards  ce8de7ab10ed34f29123d8723b13cacf00c7bf46 (commit)
  discards  c0a9bf36067363696814bf72fc3edf553e00290f (commit)
  discards  3fe133576ccdcd09b475296de01ad49aa93f3aef (commit)
  discards  b2426e6af78d6fc057e45696168c7c3d56b86584 (commit)
       via  c58270ab5fcc634839ad69b427ad4d9d34be1d1c (commit)
       via  f312b96b9c734e03de1222379a4a0305725192c2 (commit)
       via  4c0f08b58407ca8b2ca3d9502ca50212d330af63 (commit)
       via  a51b777ce0f2c178833fba4bd33cfda75a99f7a8 (commit)
       via  cf1c80f0db0b431d7cc2afe2bda4ee43d596df11 (commit)
       via  200b4689c90841ac18cc0754c7a3a95d3c4e4de4 (commit)
       via  d272b4c7c8c9e2d8a510c85896a661c312d96c0a (commit)
       via  09695de8c253ab5ee271c372ea21fd84f7377b99 (commit)
       via  fa11430d857f006459664e7314a6be79e21a20dd (commit)
       via  496aee7cb809069133fe37f39ccac7607ec6c9b3 (commit)
       via  37139e5933337e3e24f4bd83955c3492123e9ed0 (commit)
       via  1d778fdce3bc4aab16dc203463d0067f2f063d16 (commit)
       via  e47d4f6d1187d453b846ea48f95ee75a42efc23b (commit)
       via  81ffb740f78ccdada8ece786cfab852bc10172e8 (commit)
       via  841d95f86701b9e813402c65a7b1f88d132593fb (commit)
       via  8de9c48c997a84f1afbfd3306435403bdbfd9f6a (commit)
       via  79af67d7c02a25e36146369b60f7f25c9655c862 (commit)
       via  37184900e7f4f8566fbd71914f55b3cc8c0196e9 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (5a8a00afe6f037a39b407bcacdcd35bd6b399f76)
            \
             N -- N -- N (c58270ab5fcc634839ad69b427ad4d9d34be1d1c)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=c58270ab5fcc634839ad69b427ad4d9d34be1d1c

commit c58270ab5fcc634839ad69b427ad4d9d34be1d1c
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Sep 30 13:53:26 2014 +0200

    sgsn: Added TODOs (TODO)
    
    TODO:
      - fix and remove TODOs
      - add test cases for Detach(reattach)
      - add test cases for PDP context deletion (OW#1311)
      - add test cases for Cancel pending timer in sgsn_mm_ctx_free
      - remove this commit
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=f312b96b9c734e03de1222379a4a0305725192c2

commit f312b96b9c734e03de1222379a4a0305725192c2
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Oct 17 10:08:02 2014 +0200

    sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
    
    Currently an OSMO_ASSERT fails, if the message's and the mmctx's
    TLLIs do not match.
    
    This commit turns the assertion into an ERROR log message and uses
    the default values for IMSI, DRX, and RA CAP instead of the MM
    context values in this case.
    
    TODO:
      - find the real source for the problem
      - add test cases derived from what is being described in the ticket
    
    Ticket: OW#1322
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=4c0f08b58407ca8b2ca3d9502ca50212d330af63

commit 4c0f08b58407ca8b2ca3d9502ca50212d330af63
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed Dec 17 14:03:35 2014 +0100

    sgsn: Add PDP info to subscriber data (TODO)
    
    TODO:
      - commit message
      - raw binary representation ???
      - tests
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=a51b777ce0f2c178833fba4bd33cfda75a99f7a8

commit a51b777ce0f2c178833fba4bd33cfda75a99f7a8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 19 19:11:20 2014 +0100

    sgsn: Add logging to connect_timer_cb (TODO)
    
    TODO:
      - LOGLevel ?
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=cf1c80f0db0b431d7cc2afe2bda4ee43d596df11

commit cf1c80f0db0b431d7cc2afe2bda4ee43d596df11
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 26 14:43:07 2015 +0100

    sgsn: Add sgsn_mm_ctx_cleanup_free for safe shutdown
    
    Currently the MM context cleanup code is distributed over several
    functions. sgsn_mm_ctx_free not only frees data structure but also
    eventually stops the timer and does the subscriber clean-up.
    mm_ctx_cleanup_free (gprs_gmm.c) cleans up the PDP contexts and
    unassign the TLLI.
    
    This commit moves the cleanup code from both functions into a new
    unifying function sgsn_mm_ctx_cleanup_free that cares about the
    clean-up of all related sub-systems.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=200b4689c90841ac18cc0754c7a3a95d3c4e4de4

commit 200b4689c90841ac18cc0754c7a3a95d3c4e4de4
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 26 13:52:42 2015 +0100

    sgsn: Don't allow mmctx == NULL in sgsn_update_subscriber_data
    
    Currently, sgsn_update_subscriber_data can be called with mmctx ==
    NULL and will find and associate the right context (if present) based
    on the subscriber's IMSI. This will not happen in regular use
    any more, since sgsn_update_subscriber_data will only be called when
    subscribers are used (auth mode 'remote') and in this case
    gprs_subscr_get_or_create_by_mmctx will already be called by
    sgsn_auth_request. Therefore, MM context and subscriber are always
    associated except for some test cases and experimental VTY usage.
    The current implementation of sgsn_update_subscriber_data also causes
    additional complexity for the deletion on MM contexts to avoid a
    ipossible double-free MM contexts.
    
    This commit removes the MM context <-> subscriber association code
    from sgsn_update_subscriber_data. That function must always be called
    with mmctx != NULL, now. To avoid problems with VTY and test usage,
    the calling subscriber function now only call
    sgsn_update_subscriber_data when mmctx != NULL, since the purpose of
    that function is to update that state of an existing MM context after
    subscriber data has been changed.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=d272b4c7c8c9e2d8a510c85896a661c312d96c0a

commit d272b4c7c8c9e2d8a510c85896a661c312d96c0a
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 26 13:41:11 2015 +0100

    sgsn: Don't reset mm->subscr manually in sgsn_mm_ctx_free
    
    Currently the sgsn_mm_ctx_free contains code to reset the mm->subscr
    field that is also present in gprs_subscr_cleanup, which is called
    directly afterwards.
    
    This commit modifies the code path, so that the cleanup is done by
    the gprs_subscr_cleanup function. The additional reference counter
    increment is needed, since mm->subscr->mm->subscr (which is the same
    like mm->subscr) will be reset (and unref'd) within
    gprs_subscr_cleanup. Because the local variable subscr in
    sgsn_mm_ctx_free is an additional pointer to the subscriber object,
    it is consequent to adjust the reference counter when the assignment
    is done.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=09695de8c253ab5ee271c372ea21fd84f7377b99

commit 09695de8c253ab5ee271c372ea21fd84f7377b99
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 26 11:07:24 2015 +0100

    gprs: Rename gprs_subscr_delete to gprs_subscr_cleanup
    
    The old name is somewhat misleading. The function is rather preparing
    the subscriber for a subsequent subscr_free, that is possibly invoked
    by a subscr_put. It detaches the subscriber from the MM context and
    optionally invokes a PURGE_MS procedure. Therefore the _cleanup
    suffix is chosen (see mm_ctx_cleanup_free).
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=fa11430d857f006459664e7314a6be79e21a20dd

commit fa11430d857f006459664e7314a6be79e21a20dd
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Jan 26 09:22:39 2015 +0100

    gprs: Don't check for EINPROGRESS in gprs_gsup_client_create
    
    Currently, the return value of gsup_client_connect is checked whether
    it is < 0 and != -EINPROGESS. Since gsup_client_connect will only
    return a negative value on a few permanent errors (not including
    EINPROGRESS), rc is always != EINPROGRESS.
    
    This patch removes the explicit check againt -EINPROGRESS and just
    leaves the check rc < 0.
    
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 openbsc/include/openbsc/gprs_sgsn.h |  6 ++--
 openbsc/include/openbsc/sgsn.h      |  2 +-
 openbsc/src/gprs/gprs_gmm.c         | 30 +++--------------
 openbsc/src/gprs/gprs_gsup_client.c |  2 +-
 openbsc/src/gprs/gprs_sgsn.c        | 66 +++++++++++++++++++------------------
 openbsc/src/gprs/gprs_subscriber.c  | 10 +++---
 openbsc/src/gprs/sgsn_auth.c        |  2 +-
 openbsc/tests/sgsn/sgsn_test.c      | 37 +++++++++------------
 8 files changed, 66 insertions(+), 89 deletions(-)


hooks/post-receive
-- 
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)



More information about the osmocom-commitlog mailing list