openbsc.git branch jerlbeck/wip/gprs-patching updated. 0.13.0-882-ge0eb96d

gitosis at osmocom.org gitosis at osmocom.org
Thu Jan 15 18:08:48 UTC 2015


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, jerlbeck/wip/gprs-patching has been updated
  discards  64d0007aca0bc5f3c53aa3e710d9db6b745af36e (commit)
  discards  f0974ae238ee109b046051441a9599076ddcc0f0 (commit)
  discards  abf773d673a29b3e927e8151f9d47458bfeb9153 (commit)
  discards  3586c3491555ef7e686bcbc145a64ac2d9405710 (commit)
  discards  6551d3169355de7e05d94c905014ff1ec9fbf264 (commit)
  discards  145d7ddb84ef36122a0bf6a539923b558d0b3928 (commit)
  discards  5d2546d1597645a88ef70bcbdc706c9e8a16fb9a (commit)
  discards  3ea2200407b17dac2b704979bd92cb7563d51d15 (commit)
  discards  1da5e744766689acca7cf5b477a0c9bb4b900c95 (commit)
       via  e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf (commit)
       via  30550cd100ef2ed127c6ac2c29b4d745fed49e35 (commit)
       via  ea3cea021b59b8a6f9341faaf1081f031d04206c (commit)
       via  3bcbbebcc04a1f8a6e0557bd5701b97af7015c24 (commit)
       via  89be7c6d55347411aea23405236284f6e785eb57 (commit)
       via  30997b9dd3040058dea7dd7c427d2c3d63db7de0 (commit)
       via  d41ed3277136f2a35a88a8e9f04c4a52f34e47d2 (commit)
       via  c014e1ad93e620be528c6ff0cc131be08d34a8f3 (commit)
       via  427ecd1ebafe39fb95b0948b0f4b868d62186abb (commit)
       via  523731fceba3e2b805bc2e3c1205f4a7c691bad8 (commit)
       via  e341cff4a0e3f1e4525be9d216fe09cdabb0111e (commit)
       via  cabb6cbbd299a5a48a3d8eb798f747ab6383b265 (commit)
       via  c940371242ec50cd2981c69a1e6667c7f80fbbef (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (64d0007aca0bc5f3c53aa3e710d9db6b745af36e)
            \
             N -- N -- N (e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf

commit e0eb96d6a712a0278ecd00b7a1a9ba9685c306bf
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 18:51:31 2015 +0100

    sgsn: Fix P-TMSI generator's periodicity
    
    Currently sgsn_alloc_ptmsi uses rand() to get a new P-TMSI and then
    sets to upper 2 MSB. Therefore there is no lower limit of the
    distance between 2 identical P-TMSI.
    
    This patch changes the implementation to discard any random value
    above 2^30 and to generate a new random number in that case until a
    fitting number is found (or a repetition limit is reached). This way,
    all number below 2^30 within the PRNG's period are used.
    
    Ticket: OW#1362
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=30550cd100ef2ed127c6ac2c29b4d745fed49e35

commit 30550cd100ef2ed127c6ac2c29b4d745fed49e35
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Sep 30 13:53:26 2014 +0200

    sgsn: Added TODOs (TODO)
    
    TODO:
      - fix and remove TODOs
      - add test cases for Detach(reattach)
      - add test cases for PDP context deletion (OW#1311)
      - add test cases for Cancel pending timer in sgsn_mm_ctx_free
      - implement age based MM context expiry
      - remove this commit
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=ea3cea021b59b8a6f9341faaf1081f031d04206c

commit ea3cea021b59b8a6f9341faaf1081f031d04206c
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Oct 17 10:08:02 2014 +0200

    sgsn: Do not die in _bssgp_tx_dl_ud on TLLI mismatch (TODO)
    
    Currently an OSMO_ASSERT fails, if the message's and the mmctx's
    TLLIs do not match.
    
    This commit turns the assertion into an ERROR log message and uses
    the default values for IMSI, DRX, and RA CAP instead of the MM
    context values in this case.
    
    TODO:
      - find the real source for the problem
      - add test cases derived from what is being described in the ticket
    
    Ticket: OW#1322
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=3bcbbebcc04a1f8a6e0557bd5701b97af7015c24

commit 3bcbbebcc04a1f8a6e0557bd5701b97af7015c24
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed Dec 17 14:03:35 2014 +0100

    sgsn: Add PDP info to subscriber data (TODO)
    
    TODO:
      - commit message
      - raw binary representation ???
      - tests
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=89be7c6d55347411aea23405236284f6e785eb57

commit 89be7c6d55347411aea23405236284f6e785eb57
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 19 19:11:20 2014 +0100

    sgsn: Add logging to connect_timer_cb (TODO)
    
    TODO:
      - LOGLevel ?
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=30997b9dd3040058dea7dd7c427d2c3d63db7de0

commit 30997b9dd3040058dea7dd7c427d2c3d63db7de0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 8 15:29:01 2015 +0100

    gprs: Support the full cancellation procedure
    
    Currently no GSUP LocationCancellationResult message is sent back to
    the peer (HLR), if the procedure succeeded at the SGSN's side.
    
    This patch adds the missing message and put the whole request
    handling of this procedure into a separate function.
    
    Ticket: OW#1338
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=d41ed3277136f2a35a88a8e9f04c4a52f34e47d2

commit d41ed3277136f2a35a88a8e9f04c4a52f34e47d2
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 17:50:16 2015 +0100

    gprs: Don't create a subscr entry on InsertSubscriberData
    
    Currently gprs_subscr_rx_gsup_message creates a subscriber entry if
    such an entry doesn't exist for the IMSI within an
    InsertSubscriberData GSUP message. This behaviour is not compliant to
    GSM 09.02, 20.3.3.2 (Subscriber data management/SGSN) where it is
    defined, that an error ("Unidentified subscriber") shall be returned.
    
    This patch removes the case distinction, so that an existing
    subscriber entry is required for all incoming GSUP messages.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=c014e1ad93e620be528c6ff0cc131be08d34a8f3

commit c014e1ad93e620be528c6ff0cc131be08d34a8f3
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 17:08:30 2015 +0100

    gprs: Add replies for all GSUP requests
    
    Currently, an incoming GSUP request message isn't answered at all if
    it is not handled due to an error or missing implementation.
    
    This patch adds GSUP error replies for these requests (and only for
    requests). It also adds tests for these cases.
    
    Note that several of these tests check for
    GMM_CAUSE_MSGT_NOTEXIST_NOTIMPL, which will have to be changed, when
    the features are implemented.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=427ecd1ebafe39fb95b0948b0f4b868d62186abb

commit 427ecd1ebafe39fb95b0948b0f4b868d62186abb
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 8 16:23:25 2015 +0100

    gprs: Block other GSUP procedures during PURGE_MS (TODO)
    
    GSM 09.02, 19.4.1.4 mandates that no other MAP procedures shall be
    started until the PURGE_MS procedure has been completed.
    
    This patch implements this by adding corresponding state and checks
    to gprs_subscr_purge, gprs_subscr_location_update, and
    gprs_subscr_update_auth_info. If an Update Location or a Send Auth
    Info Req procedure is not started because of blocking, the retry
    mechanism is aborted to shorten the blocking time. The outstanding
    Purge MS procedure itself is not aborted.
    
    TODO:
      - testing
    
    Ticket: OW#????
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=523731fceba3e2b805bc2e3c1205f4a7c691bad8

commit 523731fceba3e2b805bc2e3c1205f4a7c691bad8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 8 15:18:39 2015 +0100

    gprs: Retry PURGE_MS procedure after timeout
    
    Currently, when the PURGE_MS_REQ to the HLR gets lost (e.g. by a
    connection or peer failure), the expired subscriber entry will not get
    deleted.
    
    This commit adds a retry mechanism then restarts the procedure after
    a timeout (currently 10s). The maximum number of retries is limited
    (currently to 3 PURGE_MS messages). If none of these procedures is
    completed (either with success or error), the subscriber data is
    deleted.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=e341cff4a0e3f1e4525be9d216fe09cdabb0111e

commit e341cff4a0e3f1e4525be9d216fe09cdabb0111e
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Jan 6 16:32:41 2015 +0100

    gprs: Use PURGE MS messages
    
    When a subscriber entry is going to be deleted by SGSN and when the
    subscriber info has been optained from a remote peer via GSUP, the
    peer should be informed before the entry is really deleted. For this
    purpose, MAP defines the PURGE MS procedure (see GSM 09.02, 19.1.4).
    
    This patch adds support for the PURGE_MS_REQ/_ERR/_RES messages and
    invokes the procedure when the subscriber entry is going to be
    removed. This only applies if GSUP is being used, the Update
    Location procedure has been completed successfully, and the
    subscriber has not been cancelled. The removal of the entry is
    delayed until a PURGE_MS_RES or PURGE_MS_ERR message is received.
    
    Note that GSM 09.02, 19.1.4.4 implies that the subscriber data is not
    to be removed when the procedure fails which is not the way the
    feature has been implemented.
    
    Note that handling 'P-TMSI freezing' is not implemented.
    
    Ticket: OW#1338
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=cabb6cbbd299a5a48a3d8eb798f747ab6383b265

commit cabb6cbbd299a5a48a3d8eb798f747ab6383b265
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Thu Jan 15 11:50:08 2015 +0100

    gprs: Implement PURGE_MS GSUP messages
    
    This commit implements the encoding and decoding of the messages
    
      - Purge MS Request
      - Purge MS Error
      - Purge MS Result
    
    and adds corresponding tests.
    
    Sponsored-by: On-Waves ehf

http://cgit.osmocom.org/openbsc/commit/?id=c940371242ec50cd2981c69a1e6667c7f80fbbef

commit c940371242ec50cd2981c69a1e6667c7f80fbbef
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Jan 9 09:46:43 2015 +0100

    sgsn/doc: Add message definitions for PURGE_MS responses
    
    Currently the definitions of the message PURGE_MS_RES and
    PURGE_MS_ERR are missing in the specification.
    
    This patch adds those definitions.
    
    Sponsored-by: On-Waves ehf

-----------------------------------------------------------------------

Summary of changes:
 openbsc/doc/sgsn-remote-protocol.txt         |   2 +
 openbsc/include/openbsc/gprs_gsup_messages.h |   6 ++
 openbsc/include/openbsc/gprs_sgsn.h          |   3 +-
 openbsc/src/gprs/gprs_gsup_messages.c        |   7 ++
 openbsc/src/gprs/gprs_sgsn.c                 |  28 ++++++-
 openbsc/src/gprs/gprs_subscriber.c           | 109 ++++++++++++++++++++++-----
 openbsc/tests/gprs/gprs_test.c               |  23 ++++++
 openbsc/tests/gprs/gprs_test.ok              |   3 +
 openbsc/tests/sgsn/sgsn_test.c               |  63 +++++++++++++++-
 9 files changed, 221 insertions(+), 23 deletions(-)


hooks/post-receive
-- 
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)



More information about the osmocom-commitlog mailing list