osmo-pcu.git branch jerlbeck/wip/edge updated. 0.2-635-g0f8e618

gitosis at osmocom.org gitosis at osmocom.org
Mon Dec 14 16:59:10 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "UNNAMED PROJECT".

The branch, jerlbeck/wip/edge has been updated
  discards  77184b9d3122246f1748e6c8a3ec074788a909f1 (commit)
  discards  c1c99ffc9aa751dd0eeb29c5368a9e4fb6357936 (commit)
  discards  7a221248338fb7fb0667060b53737f423d65c848 (commit)
  discards  c352bba2df778157575b60abd7aea8cacb53c81c (commit)
  discards  68aa8f3ce393a20ee9b98076f51dda9ca35faa2a (commit)
  discards  25eac740f0a27c5046244d5bfa8eea70c75f3d28 (commit)
  discards  5e167fd4c4110c2c00d1400cbc905dca08cbcd6b (commit)
  discards  41ac58286fcbb760c31733c518e8576990743115 (commit)
  discards  e42f5bd9e339d4a56da050a33a8619c422e24bb7 (commit)
  discards  5e269197b8a6c04dd459c534083a3b402d1031f0 (commit)
  discards  5528daf70e1d2240a16bd6ea6f7e23b59754f2f9 (commit)
  discards  b8f615c907d1220a3c4d6adac4fc9deb23a65ccc (commit)
  discards  3d409252b47fcf9a5e3005fecfeacd7fb7259ac5 (commit)
  discards  6695aabb5107dea108898d860aec388cba1e69a5 (commit)
  discards  2ebf29683d8511c145ee98751bf9e77294050992 (commit)
  discards  3faa09c7ccd32dee7631f7778cc0f62ad995962e (commit)
  discards  13061c8f9607849b7ef14c16fc1cd47575e6ba1e (commit)
  discards  5e98f456754dc9c5b11c94727dc69a69f4ed30de (commit)
  discards  27bbf719b57985de44fd57674e33d160a83a4ad2 (commit)
  discards  c1278a2c7724718dadcbe9f3e36cae9f6606c352 (commit)
  discards  8012225ccb1b0dac04b2b724aad961fe43ce38fd (commit)
  discards  ec67568de53978dfd6fa57ddee840d9985f4c99a (commit)
  discards  21c661b182b3e764a6ce3a473c6768a61bddbe52 (commit)
  discards  00c685a2bbd895b2c64bbb5d746d12b944a53036 (commit)
       via  0f8e618212e2884e8d39e57a5c41657e9bce645b (commit)
       via  5c7907a9e2e5c29eb07f82ec498c08fbf00075c8 (commit)
       via  275c31b550ae713fb3af066bd41b39e469c1fa4b (commit)
       via  70cfbe14b31392144d5f403acc52801bf2b87d11 (commit)
       via  e0eb3e8a3826299da6e4cd433875b2ec9029c5a0 (commit)
       via  2f7bb08c49a8871bc7dc94a9af1cf2eedfa63ee5 (commit)
       via  ebce5f4e98c5c4c6adad62dfe1d5482a05f7926d (commit)
       via  a342abc6f3cf3e37faf4f975429eaa4211f55087 (commit)
       via  e1d5396a55b1b11c7e951667266ec347216fc207 (commit)
       via  bab4b7dc75dfb80ba3a05168ed3f6eb81d11004d (commit)
       via  5735c14648efcaed459e7f5d3bf95430461b904f (commit)
       via  5234e5ad01de011bba632ce4f46ae4a8a9f60a59 (commit)
       via  80f559f148aec18c1db03e347c88d9331e02febc (commit)
       via  53fc0eb984c5def0cb4d093af457ba77ec82ed69 (commit)
       via  f47bbc337a8b0485165cdca85038b922f3cdec51 (commit)
       via  9e2152d10909e06b0cd0b7ef3b7ceb5e5c6f0458 (commit)
       via  42dc5e7e9c50a9564ebcb26c0aae617dcce5b4c9 (commit)
       via  b1c79b04dc8677c3487a24f2f6bbd867e5117fbd (commit)
       via  e20716086cf5507456f5d71d0ef923b10a443f06 (commit)
       via  84cf6d55cb23141cfcd07959a4db78c7b5b2a618 (commit)
       via  1fc065d98d32127665f76da657a3408f3e214ef7 (commit)

This update added new revisions after undoing existing revisions.  That is
to say, the old revision is not a strict subset of the new revision.  This
situation occurs when you --force push a change and generate a repository
containing something like this:

 * -- * -- B -- O -- O -- O (77184b9d3122246f1748e6c8a3ec074788a909f1)
             N -- N -- N (0f8e618212e2884e8d39e57a5c41657e9bce645b)

When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 0f8e618212e2884e8d39e57a5c41657e9bce645b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 11 14:53:29 2015 +0100

    DEBUG Add data log to RLC input


commit 5c7907a9e2e5c29eb07f82ec498c08fbf00075c8
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 11 14:36:53 2015 +0100

    DEBUG log Chunk info


commit 275c31b550ae713fb3af066bd41b39e469c1fa4b
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 11 16:09:41 2015 +0100

    sched: Change next_ctrl_prio increment
    Currently the control block scheduler does not seem to be fair in all
    cases. At least it happend while testing the EGPRS code, that a
    Uplink Ack/Nack message got never be sent, because a Downlink
    assignment took over all the times.
    This commit changes the round robin code to always increment the
    priority offset by 1 instead of (i + 1). The former definitely
    ensures that every message type gets the highest priority after some
    steps. The latter might be more fair in some situations, but that and
    its correctness are not proven.
    Sponsored-by: On-Waves ehf


commit 70cfbe14b31392144d5f403acc52801bf2b87d11
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Wed Dec 9 17:39:56 2015 +0100

    edge: Use a single PDCH rcv_data_block method for GPRS and EGPRS (TODO)
    Currently GPRS is handled by the old code path while EGPRS already
    uses the unified functions. The rcv_block_egprs is basically not
    specific to EGPRS and just needs minor modifications to handle GPRS.
    This commit turns gprs_rlcmac_pdch::rcv_block_egprs into a unified
    rcv_data_block method and uses it for GPRS, too.
      - check err file
    Sponsored-by: On-Waves ehf


commit e0eb3e8a3826299da6e4cd433875b2ec9029c5a0
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Dec 8 15:14:05 2015 +0100

    edge: Implement gprs_rlcmac_pdch::rcv_block_egprs
    This commit replaces the stub by a method that decodes the block
    first, and passes it to the TBF object associated with the TFI.
    Sponsored-by: On-Waves ehf


commit 2f7bb08c49a8871bc7dc94a9af1cf2eedfa63ee5
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 13:36:13 2015 +0100

    edge: Add methods for unified GPRS/EGPRS UL data block handling
    The current rcv_data_block_acknowledged_gprs method is tightly
    coupled to GPRS.
    This commit adds variants of the involved methods that support
    EGPRS and GPRS RLC encodings likewise.
    Sponsored-by: On-Waves ehf


commit ebce5f4e98c5c4c6adad62dfe1d5482a05f7926d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 13:23:15 2015 +0100

    tbf: Refactor parts of extract_tlli into set_tlli_from_ul (TODO)
    Currently gprs_rlcmac_tbf::extract_tlli takes care of decoding and
    the TBF update. These are really different things and doing the
    decoding in extract_tlli makes EGPRS support more complex.
    This commit moves the TBF state related part into a new method
     - check err file
    Sponsored-by: On-Waves ehf


commit a342abc6f3cf3e37faf4f975429eaa4211f55087
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 12:04:01 2015 +0100

    edge: Store GprsCodingScheme in gprs_rlc_data
    Currently the coding scene is stored as number N, where there scheme
    is CS-N.
    This commit replaces this by a GprsCodingScheme type cs value. The
    gprs_rlcmac_cs table is no longer needed and thus removed.
    Sponsored-by: On-Waves ehf


commit e1d5396a55b1b11c7e951667266ec347216fc207
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 11:54:29 2015 +0100

    edge: Add is_recevied and invalidate_bsn to gprs_rlc_ul_window
    These methods will be needed for EGPRS decoding.
    Sponsored-by: On-Waves ehf


commit bab4b7dc75dfb80ba3a05168ed3f6eb81d11004d
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 11:43:04 2015 +0100

    rlc: Do not raise_v_q in receive_bsn
    Currently gprs_rlc_ul_window::receive_bsn calls raise_v_q and returns
    the number of RLC data blocks that can be taken from the queue. This
    does not fit the EGPRS feature to put 2 independant data blocks in a
    single RLC block.
    This commit removes raise_v_q from receive_bsn, hence it must be
    called explicitely to get the number of processable data blocks.
    Sponsored-by: On-Waves ehf


commit 5735c14648efcaed459e7f5d3bf95430461b904f
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Dec 11 18:25:21 2015 +0100

    edge: Add test cases for rlc_data_from_ul_data
    This checks the example test cases given in appendix B of
    TS 44.060.
    Sponsored-by: On-Waves ehf


commit 5234e5ad01de011bba632ce4f46ae4a8a9f60a59
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Tue Dec 8 15:14:05 2015 +0100

    edge: Add unified decoder for GPRS/EGPRS (TODO)
    This commit adds new RLC block decoder functions that support both
    GPRS and EGPRS. The code path is selected based on the value of the
    GprsCodingScheme cs object.
     - move functions from rlc.cpp to decoding.cpp
    Sponsored-by: On-Waves ehf


commit 80f559f148aec18c1db03e347c88d9331e02febc
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 10:38:29 2015 +0100

    edge: Add information about data blocks to GprsCodingScheme
    This commit adds the methods maxDataBlockBytes and numDataBlocks
    which provide information about the data areas within RLC messages.
    In these areas, the extension bytes, TLLI, and the LLC data are
    Sponsored-by: On-Waves ehf


commit 53fc0eb984c5def0cb4d093af457ba77ec82ed69
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 11:13:30 2015 +0100

    rlc: Check endianness for bit field declarations
    Currently the declarations of rlc_ul_header, rlc_dl_header, and
    rlc_li_field silently assume that a gcc for a little endian platform
    is being used.
    This commit adds '#if OSMO_IS_LITTLE_ENDIAN' the ensure the correct
    byte ordering.
    Sponsored-by: On-Waves ehf


commit f47bbc337a8b0485165cdca85038b922f3cdec51
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 10:21:26 2015 +0100

    edge: Add header type property to GprsCodingScheme
    The header type depends on the coding scheme, for GPRS there is a
    single data header type per direction, for EGPRS there are 3 per
    direction. In addition, control block header types are used with CS-1
    only, so there is one of the per direction altogether for GRPS and
    This commit adds the header type enum and two methods headerTypeData
    and headerTypeControl.
    Sponsored-by: On-Waves ehf


commit 9e2152d10909e06b0cd0b7ef3b7ceb5e5c6f0458
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 7 15:50:35 2015 +0100

    edge: Rename rcv_data_block_acknowledged
    This commit renames rcv_data_block_acknowledged to
    rcv_data_block_acknowledged_gprs to separate it from EGPRS data block
    Sponsored-by: On-Waves ehf


commit 42dc5e7e9c50a9564ebcb26c0aae617dcce5b4c9
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Nov 30 18:09:17 2015 +0100

    edge: Add gprs_rlcmac_pdch::rcv_block_egprs stub
    This stub function gets called when an EGPRS data package arrives.
    Sponsored-by: On-Waves ehf


commit b1c79b04dc8677c3487a24f2f6bbd867e5117fbd
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 14 15:19:12 2015 +0100

    edge: Use GprsCodingScheme to adjust the UL RLC block size
    Currently the block size is mapped by a switch statement to strip
    extra bits that are not used for RLC blocks. That information is
    already available via the GprsCodingScheme class.
    This commit moves the CS/MCS detection to the rcv_block message and
    passes the cs object via rcv_block_gprs, where the length gets
    adjusted, to gprs_rlcmac_pdch::rcv_data_block_acknowledged. There the
    switch statement is removed.
    Note that the TbfTest.err changes due to an additional log message.
    Sponsored-by: On-Waves ehf


commit e20716086cf5507456f5d71d0ef923b10a443f06
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Dec 7 12:23:35 2015 +0100

    edge: Add test for GprsCodingScheme
    This test checks constructors, predicates, and operators of the
    GprsCodingScheme class.
    Sponsored-by: On-Waves ehf


commit 84cf6d55cb23141cfcd07959a4db78c7b5b2a618
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Mon Nov 30 18:06:50 2015 +0100

    edge: Add GprsCodingScheme class
    Currently the coding scheme is checked and compared at different
    places which makes in cumbersome to extend it for EGPRS.
    This class encapsules the coding scheme and provides required meta
    information like sizes as well as helper methods.
    Sponsored-by: On-Waves ehf


commit 1fc065d98d32127665f76da657a3408f3e214ef7
Author: Jacob Erlbeck <jerlbeck at sysmocom.de>
Date:   Fri Nov 27 18:10:39 2015 +0100

    edge: Extend gprs_rlcmac_dl_tbf::handle by egprs_ms_class
    The multislot (MS) class and the EGPRS MS class can also be passed
    via BSSGP in an MS Radio Access Capability element which can
    optionally be contained in a DL-UNITDATA PDU. While this case is fully
    supported for GPRS, the EGPRS MS class in BSSGP messages is ignored.
    This commit extends gprs_rlcmac_dl_tbf::handle to pass the EGPRS MS
    class, too.
    Note, that the EGPRS class is not yet taken from the CSN.1 RA
    capability and is always set to 0. Note also, that append_data
    still uses ms_class only.
    Sponsored-by: On-Waves ehf


Summary of changes:
 src/bts.cpp              | 22 +++++-------
 src/bts.h                |  7 ++--
 src/gprs_coding_scheme.h |  7 +++-
 src/rlc.cpp              |  2 +-
 src/rlc.h                | 10 +-----
 src/tbf.cpp              |  2 ++
 src/tbf_dl.cpp           | 17 ---------
 src/tbf_ul.cpp           | 90 +++++++++++++++++++++++------------------------
 tests/edge/EdgeTest.cpp  | 91 ++++++++++++++++++++++++++++++++++++++++++------
 tests/edge/EdgeTest.ok   |  2 ++
 tests/tbf/TbfTest.err    | 27 ++++++++++++++
 11 files changed, 175 insertions(+), 102 deletions(-)


More information about the osmocom-commitlog mailing list