This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-commitlog@lists.osmocom.org/.
gitosis at osmocom.org gitosis at osmocom.orgThis is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".
The branch, neels/gtphub has been updated
discards dac1a00b4cf02f2627662f9ad0e61b7dc1892e17 (commit)
discards 29c4c4999932990dfa61fe3e79802a52aef4264f (commit)
discards 02d6365ef16bfcd838d792a4797409d84f104f59 (commit)
discards e43c8c949bee886947e6759eaac5aa7c5bd453c9 (commit)
discards 5b319dd18936e75a5448a02833cc75d2bbf3a098 (commit)
discards 00362b567db211024f793d0fa850ee5736055a2b (commit)
discards b6cb4e695ecb303ce446769bdea1712a7d2ae329 (commit)
discards 33217200aa2536ecdb7e986a071134232ab9f0f6 (commit)
discards aee727f5e5b6e9877621407b93f81bab0526a614 (commit)
discards 887ed65c1828279c359cf261644d438d32c09b25 (commit)
discards 942e425d8264df165154905e6e6c7ceb04b9d667 (commit)
discards a1747a446e44ea30f12f0a4bdd1d03ee89ee106c (commit)
discards 5cfa3fcdfcb789ab9216445e2d649400b1f5d635 (commit)
discards 1676898db0638f896f963b43c7b6ce884a787706 (commit)
discards 38d337d9408623d93af46b4ec2dc2411ec7d1ca4 (commit)
discards 54520814ff53b3eadc09a484fa3e61d4a445455d (commit)
discards fc97e4549562e283d005bcb145265d585e667e3a (commit)
discards 7bc3c88667c1e96ad46f2d12d02d5d7883e281ff (commit)
discards d156ccf9ff5f29c8dc131dccd6beb0db3e207497 (commit)
discards ce4735c7fb8c8a1733028c1fd0f429c0f0af365c (commit)
discards 211b3362635d1a085c3eff05f4836f06f252b606 (commit)
discards 107cfad51f1740669c694629c0d1981538d5cf94 (commit)
discards d5662d2decd46fbc2a38130df9bdd8a485543d1a (commit)
discards 519009ecaacffbcc5d8a56690fcc7d1d810e8488 (commit)
discards ef97389fefe87d8107b4fc0cf7b34fb83cdbb3ea (commit)
discards b079b9923a812476af6ec6185c9932ea92363151 (commit)
discards a6a173ff84cf6112fc10bbbb41d13df504793942 (commit)
discards 5bab5c395c48b4dee5374d42ea6c7b895360b296 (commit)
discards cd711490c2df8f87e49adc6b82003cd915ed8d28 (commit)
discards da979ef8bbacaf1641cbf40e841a05f1e5421cba (commit)
discards 173c36b20b3163817d519aa21428448f5b16618d (commit)
discards 4defa42cf51330c087f506587f4171c3c75dc53f (commit)
discards e36599fecd68ffabd3b5d7e68aa34d48d829f93b (commit)
discards dff8c375f07b49e6cdf36352fa0d2c0a69c3faaf (commit)
discards fc78950790586b66c6f87b92603039b8703ab6a7 (commit)
discards 54bb59814699042da2c294da8eddd012c52598f8 (commit)
discards 6357d8e218408bdd2b4df861fae88e8bdeea244e (commit)
discards 9e16284e3307f0689ff1b41554da1820f1584355 (commit)
discards e82037a0873be819a65550c7948182dd3685f375 (commit)
discards 4d7dd42d9714e9c4a6aaf7ac010453f93f80cd71 (commit)
discards 91d1bb23fa35d175969382a573c7470e38c86041 (commit)
discards fa0fd33199eeba9e69c165aa5ff6f718fefab5a0 (commit)
discards 2586ba4045fa84fc0daf6ac444a757adeb033d5c (commit)
discards 3643ee36f32ca326881d78fc55a30cd6bfabb261 (commit)
discards 1d19d62d810d284a883f42814a5c389652bb2950 (commit)
via 8defadbdd2953482ad53fe9ef37bb81ff76a2097 (commit)
via 59c1b645e2d86457ee1c9df56860aec8ee5a606f (commit)
via 87c83d0b895624ac3968a85edc9de18e36d5d1ea (commit)
via d8660ef090b66e7fbbb960ce8a8c8c26f6981c6f (commit)
via c6d51f5fb477c9ebf0345edb088b86d70eb119a1 (commit)
via 996ec1d73150366fa105b7d42ba8003fb018fcf8 (commit)
via 18d304961249c7815cf3a78ebd1697a4efd9ab42 (commit)
via 237fee649e691fc3a7ef851731305b8a41921436 (commit)
via 936b890f71f6603bdd95fc6283030395743dfae5 (commit)
via be4bebaad05dd360200c38b7da02aa8ca66850f2 (commit)
via 4573ca88345c553653eeea627cf4b51fa26ab9df (commit)
via 52c0bd3025f319597ce40621ef44e39e01594605 (commit)
via bc44330671c019be92b335149a2aefa3cc08b8f7 (commit)
via 3fdba2ed5ab7ad6e0814aac37f440ea1e72c906b (commit)
via 7559910e8ced14f718820d8bfeb419878185d153 (commit)
via 99a50b3529a53429343f767023fe9ca42b61a90f (commit)
via 10fc02447279a322e1d362a31dec5c8f8bafb6f8 (commit)
via 2f67125c3237f63800c5601f1aaddda62ce192a2 (commit)
via 800126b1f33986ca9ffc6f2a65c91264a969d078 (commit)
via cd865d62f0446135258189184664a146b28db975 (commit)
via 085500807c3a66e4d6e0a6a2d6516b2a4a13e69c (commit)
via ff4b630de9b8cb760e3d30861fda807f708351d9 (commit)
via 817bc32696422ac4662b4b706c6e03961e45257b (commit)
via a9905a51f96acdddf761d0b3e4c21ac0711b57ae (commit)
via 7174b169e0346d2a44ec50b309bd1e332503c825 (commit)
via d121ea612460b8a6f78a3bc91ab164651240f48a (commit)
via f977320736fe15ffc3a0e6110bec7823a57c65ee (commit)
via ba9e9f63bce9a868b8b3e15adca616ac4dec9414 (commit)
via 8d1ffbd3ba44939612d453b161dd86ba8302d0c1 (commit)
via 005f175c3b9a3182d429de9177438564b8a7e4f6 (commit)
via fc1be3a0c1cb7a220c174c7d7d3d4bd1cd4dedf4 (commit)
via e54cd1555a874b132116b1269264de7d6cc3d24d (commit)
via 2c8b58139f3e3c29309dd6518f77a62414de560c (commit)
via 1aa0e47104d9529ecf448b81adb9ef6fb0a50c5f (commit)
via 508514c7c5a4cc2d4eae27a7e6df80b10ec4e863 (commit)
via 29d926be12fccfb2a0240535d252b7f7d8452df8 (commit)
via 231653a8d076c7c793a809de7b953c19a5e91284 (commit)
via 4b2cbdab3e29dfbd8c4b5f9d44a9a63e7553253d (commit)
via 1ba50c659801fd8ba811dd898236134c0f0a7011 (commit)
via dba6d1af697a027e9529b61925a6c78603b552a7 (commit)
via 20bd6bfef5417f540e7fdd624832d1f31e38fe42 (commit)
via 1ed9a8673d67f4224a0bdbebae012c855c5d7bdc (commit)
via b6c2db569f03bf5eb0f9a12a9bca5c0d7637beca (commit)
via d9b1d49485195a79095bae162f8bd8d0abc04781 (commit)
via 4960fab767084f9d5937960f68b84c801350f74c (commit)
via e2ed8e6cc3eef9f93d8603634072720d20821ebb (commit)
via 334af5dd9dcee962a25ca9cca9425da5d7f57a2c (commit)
This update added new revisions after undoing existing revisions. That is
to say, the old revision is not a strict subset of the new revision. This
situation occurs when you --force push a change and generate a repository
containing something like this:
* -- * -- B -- O -- O -- O (dac1a00b4cf02f2627662f9ad0e61b7dc1892e17)
\
N -- N -- N (8defadbdd2953482ad53fe9ef37bb81ff76a2097)
When this happens we assume that you've already had alert emails for all
of the O revisions, and so we here report only the revisions in the N
branch from the common base, B.
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://cgit.osmocom.org/openbsc/commit/?id=8defadbdd2953482ad53fe9ef37bb81ff76a2097
commit 8defadbdd2953482ad53fe9ef37bb81ff76a2097
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 19:14:58 2015 +0100
tests: fix condition to run sgsn, oap, gtphub tests
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=59c1b645e2d86457ee1c9df56860aec8ee5a606f
commit 59c1b645e2d86457ee1c9df56860aec8ee5a606f
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Dec 3 11:30:43 2015 +0100
gtphub: check TEI presence in Create PDP Ctx Response
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=87c83d0b895624ac3968a85edc9de18e36d5d1ea
commit 87c83d0b895624ac3968a85edc9de18e36d5d1ea
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Dec 3 11:25:27 2015 +0100
gtphub: improve logging for invalid packet
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d8660ef090b66e7fbbb960ce8a8c8c26f6981c6f
commit d8660ef090b66e7fbbb960ce8a8c8c26f6981c6f
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Dec 3 11:24:39 2015 +0100
gtphub: cosmetic
During the peer review session with Holger, these things were deemed fixable.
No need to have a static gtp_packet_desc in gtphub_handle_buf.
No need to memcpy, direct assignment does the job.
Remove obsolete comments.
Fix a stray space.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=c6d51f5fb477c9ebf0345edb088b86d70eb119a1
commit c6d51f5fb477c9ebf0345edb088b86d70eb119a1
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 15:44:34 2015 +0100
gtphub: fix restart cleanup peer matching.
Adjust test expectations accordingly.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=996ec1d73150366fa105b7d42ba8003fb018fcf8
commit 996ec1d73150366fa105b7d42ba8003fb018fcf8
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 15:43:10 2015 +0100
gtphub: wrap gtphub_write() for test suite.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=18d304961249c7815cf3a78ebd1697a4efd9ab42
commit 18d304961249c7815cf3a78ebd1697a4efd9ab42
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 15:00:50 2015 +0100
gtphub: fix use after free.
A tunnel pointer was still being checked after deleting by a call to
expiring_item_del(). 'continue' to the next tun.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=237fee649e691fc3a7ef851731305b8a41921436
commit 237fee649e691fc3a7ef851731305b8a41921436
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 14:31:45 2015 +0100
gtphub: add restart counter test
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=936b890f71f6603bdd95fc6283030395743dfae5
commit 936b890f71f6603bdd95fc6283030395743dfae5
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 14:31:08 2015 +0100
gtphub: Add a debug log
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=be4bebaad05dd360200c38b7da02aa8ca66850f2
commit be4bebaad05dd360200c38b7da02aa8ca66850f2
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 14:18:26 2015 +0100
gtphub: add test for reused TEI.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=4573ca88345c553653eeea627cf4b51fa26ab9df
commit 4573ca88345c553653eeea627cf4b51fa26ab9df
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 14:15:36 2015 +0100
gtphub: fix: add a missing NULL check
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=52c0bd3025f319597ce40621ef44e39e01594605
commit 52c0bd3025f319597ce40621ef44e39e01594605
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 14:14:32 2015 +0100
gtphub: cosmetic: early continue for less indent
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=bc44330671c019be92b335149a2aefa3cc08b8f7
commit bc44330671c019be92b335149a2aefa3cc08b8f7
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Dec 1 15:20:18 2015 +0100
gtphub: monitor GSNs' restart counters.
If a GSN indicates that it has reset, tear down each known tunnel for that GSN
individually (don't send the GSNs on the other side a different restart
counter, because they represent more than just this GSN).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=3fdba2ed5ab7ad6e0814aac37f440ea1e72c906b
commit 3fdba2ed5ab7ad6e0814aac37f440ea1e72c906b
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 14:17:21 2015 +0100
gtphub: cosmetic
Move the SGSN read callback next to the GGSN read callback.
Comments.
Tweak an initialization to NULL.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=7559910e8ced14f718820d8bfeb419878185d153
commit 7559910e8ced14f718820d8bfeb419878185d153
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Dec 1 01:01:16 2015 +0100
gtphub_test: add test for Del PDP from GGSN side.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=99a50b3529a53429343f767023fe9ca42b61a90f
commit 99a50b3529a53429343f767023fe9ca42b61a90f
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 01:15:30 2015 +0100
gtphub_test: add some cleanup asserts.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=10fc02447279a322e1d362a31dec5c8f8bafb6f8
commit 10fc02447279a322e1d362a31dec5c8f8bafb6f8
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Dec 1 00:23:45 2015 +0100
gtphub: handle Delete PDP Context.
During resolution of the header TEI, also return the tunnel struct that
resolved the TEI, so the Delete PDP Ctx code does not need to look it up
again.
Upon Delete PDP Ctx Request, remember the IEs and that a request was made.
Upon Delete PDP Ctx Response, find the pending delete and remove the
corresponding tunnel, iff the response indicates success.
Add a context deletion to regression tests, rename the test appropriately.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=2f67125c3237f63800c5601f1aaddda62ce192a2
commit 2f67125c3237f63800c5601f1aaddda62ce192a2
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 14:13:33 2015 +0100
gtphub: remove obsolete todo comment
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=800126b1f33986ca9ffc6f2a65c91264a969d078
commit 800126b1f33986ca9ffc6f2a65c91264a969d078
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 14:13:19 2015 +0100
gtphub: fix segfault when empty config.
gsn_addr_from_str(): return error upon NULL string.
Add some debug logging.
With an empty config, no bind addresses were set, and the address parser
did not check for a NULL pointer, resulting in a segfault.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=cd865d62f0446135258189184664a146b28db975
commit cd865d62f0446135258189184664a146b28db975
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 12:58:48 2015 +0100
gtphub: be more fatal about not finding an unused TEI.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=085500807c3a66e4d6e0a6a2d6516b2a4a13e69c
commit 085500807c3a66e4d6e0a6a2d6516b2a4a13e69c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 12:19:50 2015 +0100
gtphub: fix some style complaints from cppcheck
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=ff4b630de9b8cb760e3d30861fda807f708351d9
commit ff4b630de9b8cb760e3d30861fda807f708351d9
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 00:07:02 2015 +0100
gtphub: add two stubs for Delete PDP msgs
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=817bc32696422ac4662b4b706c6e03961e45257b
commit 817bc32696422ac4662b4b706c6e03961e45257b
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 23:50:45 2015 +0100
gtphub: vty: add missing SGSN-proxy output.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=a9905a51f96acdddf761d0b3e4c21ac0711b57ae
commit a9905a51f96acdddf761d0b3e4c21ac0711b57ae
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Sun Nov 29 23:49:48 2015 +0100
gtphub: refactor: use side_idx everywhere.
This is a mostly cosmetic change. Instead of separate buffer handling
functions, reduce some code duplication by using a side_idx just like the
plane_idx, with arrays.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=7174b169e0346d2a44ec50b309bd1e332503c825
commit 7174b169e0346d2a44ec50b309bd1e332503c825
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 01:22:13 2015 +0100
gtphub: make sure mapped TEIs aren't occupied (incomplete).
This could be done way better, discussion is pending/ongoing. It is indeed
quite unlikely that any user will ever hit this situation, so there is no
strong drive to invest effort in a more comprehensive implementation.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d121ea612460b8a6f78a3bc91ab164651240f48a
commit d121ea612460b8a6f78a3bc91ab164651240f48a
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 01:20:53 2015 +0100
gtphub: use a single TEI pool across planes.
There's no need to keep two separate number pools when both can be fed
from the same pool. User and Ctrl plane TEIs can technically overlap without
colliding, but it doesn't hurt if they don't overlap, either.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=f977320736fe15ffc3a0e6110bec7823a57c65ee
commit f977320736fe15ffc3a0e6110bec7823a57c65ee
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 27 00:05:56 2015 +0100
gtphub: cosmetic: for_each_side,_plane macros.
Simplify looping over sides and planes. I'm tired of typing the same for
loops all the time.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=ba9e9f63bce9a868b8b3e15adca616ac4dec9414
commit ba9e9f63bce9a868b8b3e15adca616ac4dec9414
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Nov 26 22:19:22 2015 +0100
gtphub: implement restart counter properly.
Force passing a restart counter, by adding such arg to gtphub_start() (test
suite is not affected by this).
In gtphub_main.c, add -r,--restart-file <path> and next_restart_count() to
maintain the counter file. While at it, tweak the cmdline help to unify the
formatting (mostly commas and a missing line break).
Send gtphub's own restart counter. So far, the sender's restart counter was
copied through, which would break as soon as more than one GSN would talk to
the same peer with differing restart counters.
Also fix the in-mem restart counter data type (one octet, not two).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=8d1ffbd3ba44939612d453b161dd86ba8302d0c1
commit 8d1ffbd3ba44939612d453b161dd86ba8302d0c1
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Thu Nov 26 05:20:18 2015 +0100
gtphub: complain about excess cmdline args.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=005f175c3b9a3182d429de9177438564b8a7e4f6
commit 005f175c3b9a3182d429de9177438564b8a7e4f6
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Mon Nov 30 12:19:11 2015 +0100
gtphub: fix a conditional for log output
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=fc1be3a0c1cb7a220c174c7d7d3d4bd1cd4dedf4
commit fc1be3a0c1cb7a220c174c7d7d3d4bd1cd4dedf4
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Dec 2 00:31:31 2015 +0100
gtphub: avoid segfault for incomplete tunnels.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e54cd1555a874b132116b1269264de7d6cc3d24d
commit e54cd1555a874b132116b1269264de7d6cc3d24d
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:31:06 2015 +0100
gtphub: track tunnels explicitly.
So far, gtphub worked perfectly by only tracking single TEIs ... for probably
most uses. But a Ctrl plane tunnel may have expired despite a still active
corresponding User plane tunnel. The User plane would continue to work
indefinitely, but if any Ctrl messages followed after more than six hours of
Ctrl silence, they would have been dropped due to an expired TEI mapping.
We want to
- combine expiry of a user TEI with its ctrl TEI. (done in this patch)
- upon delete PDP context, remove both user and ctrl TEI mappings. (future)
- when a peer indicates a restart counter bump, invalidate its tunnels.
(future)
To facilitate these, track tunnels, complete with both SGSN's and GGSN's
address, original and replaced TEIs, all for both user and ctrl plane, in a
single struct. A single expiry entry handles the entire tunnel, instead of
previously four separate expiries for each endpoint identifier.
Add the concept of a "side", being either GGSN or SGSN, to index tunnel
endpoint structs, and so on.
Track the originating side in the gtp_packet_desc.
Add header_tei_rx: set_tei() overwrites header_tei, but the originally received
header TEI is still needed to match a Create PDP Context Response up with its
Request (and for logging).
Adjust the test suite to expect tunnel listing strings instead of TEI mappings,
with a bonus of making it a lot easier to grok, and including the IP addresses.
Add regression test for refreshing tunnel expiry upon use.
Note: the current implementation is as slow as can possibly be, iterating all
the tunnels all the time. Optimizations are kept for a future commit, on
purpose.
BTW, the sequence number mapping/unmapping structures remain unchanged.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=2c8b58139f3e3c29309dd6518f77a62414de560c
commit 2c8b58139f3e3c29309dd6518f77a62414de560c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 25 16:45:59 2015 +0100
gtphub: cosmetic/prepare: rename expiry queues.
The expiry queues are already used for resolved GGSN addresses, and will
soon enlist tunnel structs. Hence the naming should be more general.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=1aa0e47104d9529ecf448b81adb9ef6fb0a50c5f
commit 1aa0e47104d9529ecf448b81adb9ef6fb0a50c5f
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:32:23 2015 +0100
gtphub: add assertion to ensure expiry ordering.
Make 100% sure the user adds expiring_items in chronological order by asserting
that a newly added expiry is >= the last expiry in the queue. Add llist_last()
to facilitate.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=508514c7c5a4cc2d4eae27a7e6df80b10ec4e863
commit 508514c7c5a4cc2d4eae27a7e6df80b10ec4e863
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:30:38 2015 +0100
gtphub: cosmetic/prepare: add nr_map_refresh().
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=29d926be12fccfb2a0240535d252b7f7d8452df8
commit 29d926be12fccfb2a0240535d252b7f7d8452df8
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:27:13 2015 +0100
gtphub: move timestamp into packet struct.
Instead of passing the current time around in function arguments ('now'),
rather store the current time once upon decoding a GTP packet in the
gtp_packet_desc passed around anyway ('p->timestamp').
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=231653a8d076c7c793a809de7b953c19a5e91284
commit 231653a8d076c7c793a809de7b953c19a5e91284
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 24 13:23:44 2015 +0100
gtphub: cosmetic: fix an argument name.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=4b2cbdab3e29dfbd8c4b5f9d44a9a63e7553253d
commit 4b2cbdab3e29dfbd8c4b5f9d44a9a63e7553253d
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 03:16:19 2015 +0100
gtphub: first vty show commands.
Start adding VTY commands to show rate counters / statistics / cache dumps.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=1ba50c659801fd8ba811dd898236134c0f0a7011
commit 1ba50c659801fd8ba811dd898236134c0f0a7011
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 01:28:40 2015 +0100
gtphub: add first rate counters
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=dba6d1af697a027e9529b61925a6c78603b552a7
commit dba6d1af697a027e9529b61925a6c78603b552a7
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 01:27:22 2015 +0100
gtphub: cosmetic: clarify bind pointer naming.
Some gtphub_bind pointers point to an array of binds, some point directly at
instances. Make the distinction between the two more obvious by adding an
'_arr' suffix to the array ones.
Partly in preparation for upcoming rate counters.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=20bd6bfef5417f540e7fdd624832d1f31e38fe42
commit 20bd6bfef5417f540e7fdd624832d1f31e38fe42
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 00:08:28 2015 +0100
gtphub: add explicit cleanup handles.
Clean up functionality is added for the test suite only, to be able to clean
out all allocations and test against memory leaks.
So far, it was sufficient to expire everything to free a gtphub. In preparation
for the upcoming rate counters, which will need to be freed explicitly, add
gtphub functions to clean up everything.
As added bonus, also close the sockets explicitly -- not really needed upon
program exit, neither by the test suite, but *if* we have a cleanup function,
it should clean up everything properly.
Closing the sockets is however kept separate, for the test suite.
gtphub_start() and gtphub_stop() are for normal use (published in gtphub.h),
and gtphub_init() and gtphub_free() are for the test suite, without sockets.
(gtphub_stop() will probably never be called by anyone, but its existence
completes the picture.)
In gtphub_test.c, have a function to clean up the testing gtphub struct. First,
expire everything by timeout, assert emptiness, then call the cleanup function.
Call from each test in the end.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=1ed9a8673d67f4224a0bdbebae012c855c5d7bdc
commit 1ed9a8673d67f4224a0bdbebae012c855c5d7bdc
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Fri Nov 20 00:04:41 2015 +0100
gtphub: ensure cleanup of peer addresses.
Upon calling gtphub_peer_del(), all addresses and ports should already have
expired (by force). Make sure the code heeds that with a so far missing
assertion.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=b6c2db569f03bf5eb0f9a12a9bca5c0d7637beca
commit b6c2db569f03bf5eb0f9a12a9bca5c0d7637beca
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 18:11:32 2015 +0100
gtphub: ares vty and init
From sgsn_vty.c, copy the cfg_grx_ggsn_cmd to add an ares server to the static
sgsn_instance.
This is sort of preliminary. As described in comments, the sgsn_ares functions
should actually be separated from the static sgsn structure. gtphub keeps such
an sgsn structure just for the sgsn_ares functions.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=d9b1d49485195a79095bae162f8bd8d0abc04781
commit d9b1d49485195a79095bae162f8bd8d0abc04781
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 18:11:09 2015 +0100
gtphub: review some logging.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=4960fab767084f9d5937960f68b84c801350f74c
commit 4960fab767084f9d5937960f68b84c801350f74c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Wed Nov 18 17:53:00 2015 +0100
gtphub: cosmetic: rename a file.
gtphub_ext.c's initial purpose was to wrap a specific function. The file
then turned into everything related to DNS, which fits pretty well. Rename
to gtphub_ares.c.
Tweak the header comment to reflect the new file name.
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=e2ed8e6cc3eef9f93d8603634072720d20821ebb
commit e2ed8e6cc3eef9f93d8603634072720d20821ebb
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 17 14:30:37 2015 +0100
gtphub: nr_map: add min,max and wrap.
Implement min/max bounds for nr_pool, adjust nr_pool_init() and current tests,
and create unit tests for nr_map wrapping.
Sequence numbers range from 0 to 65535, while TEIs range from 1 to 0xffffffff.
Both cause problems when the nr_pool surpasses the range: seq exit their valid
range, causing unmappings to fail, and a TEI would be mapped as zero (invalid).
Add a comment about TEI wrapping, and lose the comment about random TEIs (not
really important).
Sponsored-by: On-Waves ehi
http://cgit.osmocom.org/openbsc/commit/?id=334af5dd9dcee962a25ca9cca9425da5d7f57a2c
commit 334af5dd9dcee962a25ca9cca9425da5d7f57a2c
Author: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Date: Tue Nov 17 14:24:46 2015 +0100
gtphub: fix number map range for TEIs.
Use unsigned int for nr_map, just large enough to fit the TEI space.
Adjust log output formats and casts accordingly.
Fixes: TEIs are uint32_t, but the nr_map so far used int. This would cause TEIs
from 0x80000000 on to be handled and printed as a negative value.
Sponsored-by: On-Waves ehi
-----------------------------------------------------------------------
Summary of changes:
openbsc/src/gprs/gtphub.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
hooks/post-receive
--
The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)