libosmocore.git branch master updated. 0.8.0-20-g8d192d7

gitosis at gitosis at
Tue Apr 7 18:11:47 UTC 2015

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  8d192d7153498498ff6232209c900e67256b8036 (commit)
       via  b535e391b0f1d030373159ddbf54483d7fa54763 (commit)
       via  c641591ae9298894178dae78c37e5f96687be576 (commit)
       via  a11994ddff1edbdb85ee9dc1ffd36f9b9834edf3 (commit)
      from  5fb265eaa725928b59b44aa9bfe8959256014ba1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 8d192d7153498498ff6232209c900e67256b8036
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Apr 7 17:52:45 2015 +0200

    ns: Log when sending fails (Coverity)
    Currently the return value of the gprs_ns_tx family of functions is
    often ignored. This is not a serious issue, since the successful
    delivery of the messages is neither guaranteed nor acknowledged by
    the network layer anyway.
    Nevertheless this commit adds logging (level INFO) to gprs_ns_tx and
    gprs_ns_msgb_alloc. The definition of the latter has been moved from
    the header file to gprs_ns.c.
    Fixes: Coverity CID 1040678, 1040679, 1040680, 1040681, 1040682,
       1040683, 1040684, 1040686, 1040687, 1040688, 1111545,
       1240203, 1240204
    Sponsored-by: On-Waves ehf

commit b535e391b0f1d030373159ddbf54483d7fa54763
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Apr 7 17:52:44 2015 +0200

    bssgp: Ensure non-NULL bctx before calling bssgp_rx_ptp (Coverity)
    Currently bssgp_rx_ptp might be called with bctx being NULL, when the
    NS BVCI is neither BVCI_SIGNALLING nor BVCI_PTM, but the message is
    a BVC_RESET or it contains an BVCI IE != BVCI_SIGNALLING where the
    BVCI is not known.
    This patch ensures that bssgp_rx_ptp will only be called with a
    non-NULL bctx. A log message will be issued, if the bctx is NULL when
    this was not expected.
    Fixes: Coverity CID 1040674
    Sponsored-by: On-Waves ehf

commit c641591ae9298894178dae78c37e5f96687be576
Author: Jacob Erlbeck <jerlbeck at>
Date:   Tue Apr 7 17:52:43 2015 +0200

    bssgp: Always expect dup != NULL in bssgp_tx_dl_ud (Coverity)
    Currently the implementation of bssgp_tx_dl_ud conditionally adds
    some optional IE if dup != NULL. Later on is dereferences dup to
    access qos_profile and fc, but this without checking dup in advance.
    This may lead to an segmentation violation fault.
    This commit changes the value range of the function to only accept
    dup != NULL. An assertion will fail otherwise. All other explicit
    checks for non-NULL are removed.
    Fixes: Coverity CID 1040673
    Sponsored-by: On-Waves ehf

commit a11994ddff1edbdb85ee9dc1ffd36f9b9834edf3
Author: Max <max.suraev at>
Date:   Mon Apr 6 16:17:49 2015 +0200

    fix compiler warnings for a5 tests
    Signed-off-by: Max <max.suraev at>


Summary of changes:
 include/osmocom/gprs/gprs_ns.h | 10 +++-----
 src/gb/gprs_bssgp.c            | 56 ++++++++++++++++++++++--------------------
 src/gb/gprs_ns.c               | 19 ++++++++++++++
 src/gb/           |  1 +
 tests/a5/a5_test.c             |  4 +++
 tests/gb/gprs_bssgp_test.c     | 17 +++++++++++++
 6 files changed, 75 insertions(+), 32 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list