<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Herald any update on this?</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
BR</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Snehasish Kar <snehasish.cse@live.com><br>
<b>Sent:</b> Monday, December 31, 2018 7:04 PM<br>
<b>To:</b> Harald Welte<br>
<b>Cc:</b> openbsc@lists.osmocom.org<br>
<b>Subject:</b> Re: Adding priority for EMLPP service in paging type 1</font>
<div> </div>
</div>
<style type="text/css" style="display:none">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hello Harald</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
I have been able to add priority to the paging and setup command, though it is hard-coded now, but still please check it and let me know if I am correct or wrong.</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div style="font-family:Calibri,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
diff --git a/<span style="margin:0px; color:black; background-color:yellow">openbsc</span>/src/libbsc/abis_rsl.c b/<span style="margin:0px; color:black; background-color:yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
index 5a508b207..5b45cd497 100644<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
--- a/<span style="margin:0px; color:black; background-color:yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
+++ b/<span style="margin:0px; color:black; background-color:yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
@@ -1034,6 +1034,8 @@ int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
if (bts->type == GSM_BTS_TYPE_RBS2000 && is_gprs)<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
msgb_tv_put(msg, RSL_IE_ERIC_PACKET_PAG_IND, 0);<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
+ msgb_tv_put(msg, RSL_IE_EMLPP_PRIO, 0x7f); <br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
+<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
msg->dst = bts->c0->rsl_link;</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
diff --git a/openbsc/src/libmsc/gsm_04_08.c b/openbsc/src/libmsc/gsm_04_08.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
index 09e35cce2..a7ba85744 100644<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
--- a/openbsc/src/libmsc/gsm_04_08.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
+++ b/openbsc/src/libmsc/gsm_04_08.c<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
@@ -2376,7 +2376,7 @@ static int gsm48_cc_tx_setup(struct gsm_trans *trans, void *arg)<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
/* signal */<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
if (setup->fields & MNCC_F_SIGNAL)<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
gsm48_encode_signal(msg, setup->signal);<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
-<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
+ msgb_v_put(msg,GSM48_IE_PRIORITY_LEV | 0xf);<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
new_cc_state(trans, GSM_CSTATE_CALL_PRESENT);<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
rate_ctr_inc(&trans->net->msc_ctrs->ctr[MSC_CTR_CALL_MT_SETUP]);</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
<br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:rgb(255,255,255)">
<br>
</div>
<span>diff --git a/src/common/paging.c b/src/common/paging.c<br>
</span>
<div>index aa604e7..092da05 100644<br>
</div>
<div>--- a/src/common/paging.c<br>
</div>
<div>+++ b/src/common/paging.c<br>
</div>
<div>@@ -293,7 +293,7 @@ static int fill_paging_type_1(uint8_t *out_buf, const uint8_t *identity1_lv,<br>
</div>
<div> cur = tlv_put(cur, GSM48_IE_MOBILE_ID, identity2_lv[0], identity2_lv+1);<br>
</div>
<div> <br>
</div>
<div> pt1->l2_plen = L2_PLEN(cur - out_buf);<br>
</div>
<div>-<br>
</div>
<div>+ cur = v_put(cur,/*priority*/0x7f);<br>
</div>
<div> return cur - out_buf;<br>
</div>
<div> }<br>
</div>
<div><br>
</div>
<div><br>
</div>
<div>I have attached the wireshark traces please check. Also there is a wireshark dump with airprobe to see whether the paging messages are correctly being transported or not.</div>
<div><br>
</div>
<div>BR</div>
<div>Snehasish</div>
<span></span><br>
</div>
<div style="margin:0px; font-family:Calibri,Helvetica,sans-serif,serif,EmojiFont; background-color:white">
<br>
</div>
<br>
</div>
<div id="x_appendonsend"></div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Harald Welte <laforge@gnumonks.org><br>
<b>Sent:</b> Thursday, December 27, 2018 2:28 AM<br>
<b>To:</b> Snehasish Kar<br>
<b>Cc:</b> openbsc@lists.osmocom.org<br>
<b>Subject:</b> Re: Adding priority for EMLPP service in paging type 1</font>
<div> </div>
</div>
<div class="x_BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="x_PlainText">Hi Snehasish,<br>
<br>
On Wed, Dec 26, 2018 at 02:13:38PM +0000, Snehasish Kar wrote:<br>
> Please find the updated patches:<br>
<br>
Thanks, there were no requested related pcap traces, though.<br>
<br>
I think you are making the wrong assumption that you can simply add a byte<br>
to the RSL message which then magically appears on the Um interface. Instead,<br>
you need to study how eMLPP is actually implemented over Abis. There's an additional<br>
information element that needs to be added to the RSL PAGING COMMAND, see Section<br>
8.5.5 of 3GPP TS 48.058. The IE is of type TV, so you need to msgb_put_tv(...)<br>
to add it.<br>
<br>
Furthermore, you will need to teach OsmoBTS (assuming you are using OsmoBTS) to<br>
interpret that additional IE and then construct the air interface paging rest<br>
octets from it.<br>
<br>
Please also notice that openbsc.git is no longer maintained anymore and it is<br>
strongly suggested you switch to the new "split NITB" architecture consisting of<br>
osmo-bsc.git + osmo-msc.git + osmo-hlr.git.<br>
<br>
We're very much looking forward to receiving your patches contributing eMLPP<br>
support to the Osmocom stack.<br>
<br>
Regards,<br>
Harald<br>
<br>
-- <br>
- Harald Welte <laforge@gnumonks.org> <a href="http://laforge.gnumonks.org/">
http://laforge.gnumonks.org/</a><br>
============================================================================<br>
"Privacy in residential applications is a desirable marketing option."<br>
(ETSI EN 300 175-7 Ch. A6)<br>
</div>
</span></font></div>
</div>
</body>
</html>