<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<!--[if lte mso 15 || CheckWebRef]-->
<div id="OwaReferenceAttachments" contenteditable="false">
<table style="padding-bottom: 13px; border-width: 0px; border-style: none;">
<tbody>
<tr valign="top">
<td>
<table style="border-width: 0px 0px 1px 0px; border-color:#C7C7C7; border-style: none none dotted none;">
<tbody>
<tr valign="top">
<td style="padding-bottom:7px;">
<table align="left" style="padding-right: 28px; border-width: 0px; background-color: rgb(255, 255, 255); border-spacing: 0px">
<tbody>
<tr valign="top">
<td style="padding: 0px;">
<div id="OwaReferenceAttachmentDescription" style="padding-left: 3px; font-size: 14px; font-family: 'Segoe UI', 'Segoe WP', 'Segoe UI WPC', Tahoma, Arial, sans-serif; color: rgb(102, 102, 102);">
Snehasish Kar has shared a OneDrive file with you. To view it, click the link below.
</div>
</td>
</tr>
</tbody>
</table>
</td>
</tr>
<tr valign="top">
<td><a href="https://1drv.ms/u/s!Ar2IfAyw5vH1gQsxLkqbowdVcPya" target="_blank">
<table align="left" style="padding-right: 28px; padding-bottom:10px; border-width: 0px; height:20px; background-color: rgb(255, 255, 255); border-spacing: 0px">
<tbody>
<tr valign="top">
<td style="padding: 0px;">
<div style="background-color: rgb(255, 255, 255); height: 20px; width: 20px; max-height: 20px;">
<a href="https://1drv.ms/u/s!Ar2IfAyw5vH1gQsxLkqbowdVcPya" target="_blank"><img width="20" style="border:0px;" src="https://r1.res.office365.com/owa/prem/images/dc-generic_20.png"></a></div>
</td>
<td>
<div id="OwaReferenceAttachmentFileName2" style="padding: 0px 0px 0px 5px; font-size: 14px; font-family: 'Segoe UI', 'Segoe WP', 'Segoe UI WPC', Tahoma, Arial, sans-serif; color: rgb(0, 114, 198);">
<a href="https://1drv.ms/u/s!Ar2IfAyw5vH1gQsxLkqbowdVcPya" target="_blank" style="text-decoration: none; margin: 0px; font-size: 14px; font-family: 'Segoe UI', 'Segoe WP', 'Segoe UI WPC', Tahoma, Arial, sans-serif; color: rgb(0, 114, 198);">emlpp_test.pcapng</a></div>
</td>
<td style="display:none;visibility:hidden;" width="0" height="0"><img width="0" height="0" style="visibility:hidden;border:0px;display:none" src="dummy.jpg" originalsrc="cid:544fe5b4-f229-4527-8990-fcaddb0f39cf" title="emlpp_test.pcapng"></td>
</tr>
</tbody>
</table>
</a></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
<div id="OwaReferenceAttachmentsEnd" style="display:none;visibility:hidden;"></div>
<!--[endif]--><!--[if lte mso 15 || CheckWebRef]--><!--[endif]-->
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hello Harald</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I have updated the abis_rsl.c. But I have a small confusion, please correct me, the IE for EMLPP is of 2 Bytes out of which the second octet contains only last 3 bits as priority and msgb_tv_put allows to set only one octet, thus on setting anything above 5
it shows call_priority as 0 and anything less than that as 4. Please let me know where I am going wrong.Below is the patch and pcap has been attached. <span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; background-color: rgb(255, 255, 255); display: inline !important"><span style="font-family: "Segoe UI", "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; background-color: rgb(255, 255, 255); display: inline !important"> </span></span></div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
diff --git a/<span style="margin: 0px; color: black; background-color: yellow">openbsc</span>/src/libbsc/abis_rsl.c b/<span style="margin: 0px; color: black; background-color: yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
index 5a508b207..5b45cd497 100644<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
--- a/<span style="margin: 0px; color: black; background-color: yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
+++ b/<span style="margin: 0px; color: black; background-color: yellow">openbsc</span>/src/libbsc/abis_rsl.c<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
@@ -1034,6 +1034,8 @@ int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, uint8_t len,<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
if (bts->type == GSM_BTS_TYPE_RBS2000 && is_gprs)<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
msgb_tv_put(msg, RSL_IE_ERIC_PACKET_PAG_IND, 0);<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
+ msgb_tv_put(msg, RSL_IE_EMLPP_PRIO, 0x00); <br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
+<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
msg->dst = bts->c0->rsl_link;</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
<br>
</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
Best Regards</div>
<div style="margin: 0px; font-family: Calibri, Helvetica, sans-serif, serif, EmojiFont; background-color: rgb(255, 255, 255)">
Snehasish</div>
<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Harald Welte <laforge@gnumonks.org><br>
<b>Sent:</b> Thursday, December 27, 2018 2:28 AM<br>
<b>To:</b> Snehasish Kar<br>
<b>Cc:</b> openbsc@lists.osmocom.org<br>
<b>Subject:</b> Re: Adding priority for EMLPP service in paging type 1</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Hi Snehasish,<br>
<br>
On Wed, Dec 26, 2018 at 02:13:38PM +0000, Snehasish Kar wrote:<br>
> Please find the updated patches:<br>
<br>
Thanks, there were no requested related pcap traces, though.<br>
<br>
I think you are making the wrong assumption that you can simply add a byte<br>
to the RSL message which then magically appears on the Um interface. Instead,<br>
you need to study how eMLPP is actually implemented over Abis. There's an additional<br>
information element that needs to be added to the RSL PAGING COMMAND, see Section<br>
8.5.5 of 3GPP TS 48.058. The IE is of type TV, so you need to msgb_put_tv(...)<br>
to add it.<br>
<br>
Furthermore, you will need to teach OsmoBTS (assuming you are using OsmoBTS) to<br>
interpret that additional IE and then construct the air interface paging rest<br>
octets from it.<br>
<br>
Please also notice that openbsc.git is no longer maintained anymore and it is<br>
strongly suggested you switch to the new "split NITB" architecture consisting of<br>
osmo-bsc.git + osmo-msc.git + osmo-hlr.git.<br>
<br>
We're very much looking forward to receiving your patches contributing eMLPP<br>
support to the Osmocom stack.<br>
<br>
Regards,<br>
Harald<br>
<br>
-- <br>
- Harald Welte <laforge@gnumonks.org> <a href="http://laforge.gnumonks.org/">
http://laforge.gnumonks.org/</a><br>
============================================================================<br>
"Privacy in residential applications is a desirable marketing option."<br>
(ETSI EN 300 175-7 Ch. A6)<br>
</div>
</span></font></div>
</body>
</html>