<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Hi Folks,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">When I build OpenBsc, I find a number of cases where libosmovty isn’t in the link, but is needed by libosmoabis (basically anywhere libosmoabis is linked, but vty isn’t) e.g.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">/bin/ld: warning: libosmovty.so.1, needed by /.build/usr/local/lib/libosmoabis.so, not found (try using -rpath or -rpath-link)<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_node'<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element_ve'<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out_rate_ctr_group'<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_out'<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `install_element'<o:p></o:p></p>
<p class="MsoNormal">/.build/usr/local/lib/libosmoabis.so: undefined reference to `vty_install_default'<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’m not sure why/how I’m seeing this and others apparently aren’t, but it looks legitimate. I’ve verified the configure script has [correctly] derived build configfrom the staged pkgconfig:<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">LIBOSMOABIS_CFLAGS='-I/.build/usr/local/include/ '<o:p></o:p></p>
<p class="MsoNormal">LIBOSMOABIS_LIBS='-L/.build/usr/local/lib -losmoabis ' <o:p>
</o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">So I wonder if libosmoabis.pc.in should be updated to include vty, a bit like libosmogb.pc.in i.e.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Signed-off-by: Michael McTernan <Michael.McTernan@wavemobile.com><o:p></o:p></p>
<p class="MsoNormal">--- libosmoabis.pc.in (revision 19495)<o:p></o:p></p>
<p class="MsoNormal">+++ libosmoabis.pc.in (working copy)<o:p></o:p></p>
<p class="MsoNormal">@@ -6,6 +6,6 @@<o:p></o:p></p>
<p class="MsoNormal">Name: A-bis Core Library<o:p></o:p></p>
<p class="MsoNormal">Description: C Utility Library<o:p></o:p></p>
<p class="MsoNormal">Version: @VERSION@<o:p></o:p></p>
<p class="MsoNormal">-Libs: -L${libdir} -losmoabis<o:p></o:p></p>
<p class="MsoNormal">+Libs: -L${libdir} -losmoabis -losmovty<o:p></o:p></p>
<p class="MsoNormal">Cflags: -I${includedir}/<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Otherwise every user of libosmoabis has to remember to link with –losmovty as well.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Kind Regards,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Mike<o:p></o:p></p>
<p class="MsoNormal">PS: I’ve stripped the very long full build paths from output – I don’t really build in /.build!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>