<div class="gmail_quote">2012/10/16 Pablo Neira Ayuso <span dir="ltr"><<a href="mailto:pablo@gnumonks.org" target="_blank">pablo@gnumonks.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

This was recently changed to perform robust error handling.<br>
<br>
But thinking it's too much to close the signalling link on recoverable<br>
errors coming from the signalling layer.<br>
<br>
Would you give a try to the following patch? Thanks.<br>
</blockquote></div><br>Hi Pablo,<br>thanks for the patch.<br><br>msgb_free(msg); causes signal 6, I tried the following and it works, but might cause a memory leak...<br><br>    if (e1i_ts->line->ops->sign_link(msg) < 0) {<br>
        /* Don't close the signalling link if the upper layers report<br>         * an error, that's too strict.<br>         */<br>        LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"<br>            "sign_link returned error\n");<br>
        ret = -EINVAL;<br>        //msgb_free(msg);<br>        return(ret);<br>    }<br><br>LM<br>