osmo-hlr VTY tests failing on master

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pau Espin Pedrol pespin at sysmocom.de
Tue Aug 20 08:43:26 UTC 2019


Hi,

it seems related to libosmocore 
d0b3b9edac978c91bf84aa2537aa24426685b1fb, where logp VTY command is added

Mismatch:
Expect:
'  show talloc-context (application|all) (full|brief|DEPTH)'
Got:
'  logp 
(main|db|auc|ss|lglobal|llapd|linp|lmux|lmi|lmib|lsms|lctrl|lgtp|lstats|lgsup|loap|lss7|lsccp|lsua|lm3ua|lmgcp|ljibuf|lrspro) 
(debug|info|notice|error|fatal) .LOGMESSAGE'


The problem is osmo-hlr test_node.vty doesn't skip library-related 
commands, so updating the lib can trigger this kind of issues.

Quick fix is in libosmocore. Move the new command upwards:


Expected:
[
OsmoHLR> list
   show version
   show online-help
   list
   exit
   help
   enable
   terminal length <0-512>
   terminal no length
   who
   show history
   logging enable
...
   show logging vty
   show alarms        <------ logp appears here after "show alarms" 
nowadays.
   show talloc-context (application|all) (full|brief|DEPTH)
   show talloc-context (application|all) (full|brief|DEPTH) tree ADDRESS
   show talloc-context (application|all) (full|brief|DEPTH) filter REGEXP
   show stats
   show stats level (global|peer|subscriber)
   show asciidoc counters
   show rate-counters
   show gsup-connections
   subscriber (imsi|msisdn|id|imei) IDENT show
   show subscriber (imsi|msisdn|id|imei) IDENT
]


I submitted a patch to fix the issue:
https://gerrit.osmocom.org/c/libosmocore/+/15244 vty: Register logp cmd 
next to logging commands


-- 
- Pau Espin Pedrol <pespin at sysmocom.de>         http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte



More information about the OpenBSC mailing list