voting in gerrit: merge at +3? (+2+1 / +1+1+1)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Oliver Smith osmith at sysmocom.de
Fri Nov 16 09:47:43 UTC 2018


On 11/15/18 7:19 PM, Stefan Sperling wrote:
> So please don't stop voicing your opinions.

For what it's worth, I would prefer to enforce the rule as well. Even if
it does not seem like much effort to explain this workflow to new users,
and to ask people to think about the +3 before merging: these things add
up, leave room for mistakes and scale badly (as already pointed out in
this thread).

It's the same with CI that builds code and runs test cases - of course
we could trust everybody to do this on their own before publishing
patches, but that is not as good as checking it automatically and having
proof that the tests really ran through before merging.

Best regards,
Oliver

-- 
- Oliver Smith <osmith at sysmocom.de>            https://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte



More information about the OpenBSC mailing list