voting in gerrit: merge at +3? (+2+1 / +1+1+1)

Max msuraev at sysmocom.de
Wed Nov 14 14:04:03 UTC 2018


Hi.

I really like this idea: merging at +3 seems like a nice balance between 
not letting code go into master unchecked and having all the reviews by 
few people only.

If some patch really got to be merged ASAP than I don't think it would 
be that hard to get extra +1 necessary: just ask at #osmocom :)

I think giving everybody ability to +2 patches and merge them right away 
defeats the very purpose of having code review system in a first place - 
we could just merge to master directly in this case.

-- 
- Max Suraev <msuraev at sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Harald Welte



More information about the OpenBSC mailing list