libosmocore / rate_ctr / osmo_fsm / invalid identifiers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte hwelte at sysmocom.de
Tue Oct 24 17:12:24 UTC 2017


Dear Osmocom comunity,

after my patches being in gerrit since October 3 without getting any
significant review comments, I decided to rebase+merge the code to
enforce correct "identifiers" for entnties like rate_ctr or osmo_fsm
which get registered to libosmocore and which are subsequently
automatically exported via CTRL.

A valid identifier is from now on known as any 7-bit ASCII string
excluding characters from the following set:
	:., {}[]()<>|~\\^`'\"?=;/+*&%$#!

This has caused some (not entirely unexpected) breakage in osmo-bts.git
and osmo-bsc.git and is the cause of a couple of "red" Jenkins builds
for those projects.  I've quickly followed-up with patches for those
two repositories to make sure other people/patches don't suffer from
fall-out.

What's important to note from now on and in the future:
* don't use any string identifiers that violate osmo_identifier_valid()
* check the return value of calls like osmo_fsm_register() as they may
  fail if your identifiers are incorrect
* use ':' as separator in rate_ctr_group or rate_ctr names.  Any existing
  '.' will be transparently converted to ':' for compatibility reasons.
* if you find other sub-systems in the libosmo* universe that use string
  identifiers for certain objects, let's try to introduce calls to
  osmo_identifier_valid() in all of their registration paths to ensure
  that we could later on add automatic export of such objects to CTRL
  or other interfaces without having to change the name at that point.
  Things that come to my mind are e.g.
  * SCCP global titles and AS/ASP names in libosmo-sigtran
  * SMPP ESME names in osmo-{msc,nitb}
  Patches welcome!

Regards,
	Harald
-- 
- Harald Welte <hwelte at sysmocom.de>             http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte



More information about the OpenBSC mailing list