LOGPFSM

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Mon Nov 20 11:30:18 UTC 2017


Hi dexter,

I just noticed this patch that is merged, with the lines

+ LOGPFSML(reset->fsm, LOGL_NOTICE, "fsm-state (msc-reset): %s, fsm-event: %s\n",
           get_value_string(fsm_state_names, ST_CONN), get_value_string(fsm_evt_names, event));

If you take a look at the log output this produces, you should see that LOGPFSM
already contains information that it is an FSM, which state it is in, and that
just before that an FSM event has fired. This log statement seems obsolete?

Here's an example where you did everything right, just add a message to the FSM
logging:

+ LOGPFSML(reset->fsm, LOGL_NOTICE, "SIGTRAN connection down, reconnecting...\n");

I marked in the (merged) patch those logging lines that seem to merely
duplicate what we already see in the logs: https://gerrit.osmocom.org/4754

~N
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20171120/69ad2dd8/attachment.bin>


More information about the OpenBSC mailing list