This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/82/1/include/osmocom/trau/osmo_ortp.h
File include/osmocom/trau/osmo_ortp.h:
PS1, Line 69: smo_rtp_send_frame(struct osmo_rtp_socket *rs, const uint8_t *payload,
: unsigned int payload_len, unsigned int duration,
: bool marker);
The question is, do we want to break API+ABI deliberately to add this argument, or do we rather add a new osmo_rtp_send_frame2() function that has the new argument? This way we can support both old and new openbsc/osmo-bts from one given (new) libosmo-abis installation.
--
To view, visit https://gerrit.osmocom.org/82
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23e6dccfad5643e662391a0a2abebbb45597ffd9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes