test-ranap failures

[Harald Welte]

On Mon, May 02, 2016 at 02:53:33PM +0200, Neels Hofmeyr wrote:
> I found that it is introduced by 14da5411a4fbe05eccff5b4f0934d52773a3f97a
> ("test-ranap: Add test case about constrained integer range decode")
> -- merely a missing free of the decoded RANAP_Cause_t*.

thanks for spotting it.

> However, when warping back to that commit I also see an unexpected reversal of
> the byte order of two bytes in six places, introduced in f764a15c2339d5b24f
> ("Add test case about RANAP MaxBitrate encoding") and later secretly fixed in

> bb289e3b810683d ("RAB parameters: add Extended Max Bitrate") which is actually
> my commit but now appears in master as authored by you. 

My apologies for this.  I spotted it only after I had pushed it to
git.osmocom.org.  I don't know how this happened, I just used git rebase
-i and did some manual editing/merging associated with that.  Not sure
why git changed the author information, that's clearly not my intention.

> -        14 00 3C 40 00 00 00 50 3D 02 02 00 0D C0 35 00 
> +        14 00 3C 40 00 00 00 50 3D 02 00 02 0D C0 35 00 

> I'm not sure how this reversal came to be in test-ranap.ok. All I know is it
> works in master's HEAD, but not in 14da5411a4fbe05eccff5b4f0.

do you know in which part of the message the byte reversal is happening?

did you actually check on your system tu build + run test-ranap in both
master and the 14da5411a4fbe05eccff5b4f0 commit?

I suspect the difference is actually related to the fact that I switched
to an updated/fixed libasn1c in between, something that's unfortunately
not visible in the git changelog of osmo-iuh.git :/

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)