[PATCH 1/7] Add MM Auth test; add auth_action_str() function

[Neels Hofmeyr]

On Sun, Mar 27, 2016 at 10:53:53AM +0200, Harald Welte wrote:
> Hi Neels,
> 
> On Sat, Mar 26, 2016 at 09:35:33PM +0100, Neels Hofmeyr wrote:
> > +static inline const char *auth_action_str(enum auth_action a)
> 
> we normally try to avoid introducing some custom value/string converter
> code like this and use 'struct value_string' for this.

ah :)
(sorry for the noise from previous mail)

> > +#define AUTH_CASE(X) \
> > +	case X: return #X
> 
> you can also define a macro like this that generates a
> 	{ X, #X },
> for struct value_string
> > +	case -1:
> > +		return "(internal error)";
> 
> this would be an ugly
> 
> 	{ -1, "(internal error") }
> 
> which is soon replaced by your #define AUTH_ERROR anyway.

yes, I preferred to first have the test suite in place before introducing
more enum values...

> ... and please refrain from having non-trivial functions (or data
> definitions), and particularly non-performance-critical functions like
> this inline in a header file.

ack

> I would merge the entire patch-set, if you could address that one issue. Thanks!

great, am onto it!

~Neels

-- 
- Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160329/3a945e4e/attachment.bin>