[PATCH 2/3] Improve BSSGP debug output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Fri Mar 11 15:32:41 UTC 2016


On Wed, Mar 09, 2016 at 12:29:24PM +0100, msuraev at sysmocom.de wrote:
> Print string representation of Cause IE and PDU type in addition to
> numerical value.

thanks. I'd like to merge, but

> -		DEBUGP(DBSSGP, "BSSGP BVCI=%u Rx PDU type 0x%02x not [yet] "
> -			"implemented\n", bctx->bvci, pdu_type);
> +		DEBUGP(DBSSGP, "BSSGP BVCI=%u Rx PDU type 0x%02x (%s) not [yet] "
> +		       "implemented\n", bctx->bvci, pdu_type, bssgp_pdu_str(pdu_type));

pleaes remove the 0x%02x numeric printing.  The %s via bssgp_pdu_str()
will automatically fall back to printing the numeric type as "unknown
0x%x" when it is unknown, as part of the  value_string implementation,
IIRC.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list