include grouping

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Jul 13 14:21:56 UTC 2016


Hi Max,

in e.g. e6052c4cc756f7d3a5023a0ba57fe8d80783967c you have added #include
<stdbool.h> in various files.

I'd like to nitpick about the place where you put it:

index 3cba5d1..3d7c244 100644
--- a/openbsc/include/openbsc/gsm_subscriber.h
+++ b/openbsc/include/openbsc/gsm_subscriber.h
@@ -5,6 +5,8 @@
 #include <osmocom/core/linuxlist.h>
 #include <osmocom/gsm/protocol/gsm_23_003.h>
 
+#include <stdbool.h>
+

(there are also some more instances)

I'd prefer if we keep system headers grouped on top.
Thanks :)

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160713/e2db752c/attachment.bin>


More information about the OpenBSC mailing list