[PATCH] Extend L1SAP PH-DATA with presence information

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Fri Feb 19 18:47:36 UTC 2016


> On 19 Feb 2016, at 19:17, msuraev at sysmocom.de wrote:
> 
> 

good!


> 
> +/*! \brief PH-DATA presence information */
> +enum osmo_ph_pres_info_type {
> +	PRES_INFO_INVALID = 0,	/*!< \brief Data is invalid */
> +	PRES_INFO_HEADER  = 1,	/*!< \brief Only header is present and valid */
> +	PRES_INFO_FIRST   = 3,	/*!< \brief First half of data + header are valid (2nd half may be present but invalid) */
> +	PRES_INFO_SECOND  = 5,	/*!< \brief Second half of data + header are valid (1st halfmay be present but invalid) */
> +	PRES_INFO_BOTH    = 7,	/*!< \brief Both parts + header are present and valid */


do you intend to use it as a bit mask or why the b101 and b111?



> +	PRES_INFO_UNKNOWN
> +};
> +
> /*! \brief for PH-RANDOM_ACCESS.req */
> struct ph_rach_req_param {
> 
> +	enum osmo_ph_pres_info_type pdch_presence_info; /*!< \brief Info regarding presence/validity of header and data parts */
> };

This might or might not change the size of the struct osmo_phsap_prim and then we have an ABI issue. For such cases we have created the TODO-RELEASE file to indicate that we need to bump the SOVERSION on the next release.


holger


More information about the OpenBSC mailing list