[PATCH 1/4] gprs_gmm: ensure llme present upon Attach Req (CID #57686)

Neels Hofmeyr nhofmeyr at sysmocom.de
Thu Apr 28 11:27:11 UTC 2016


On Mon, Apr 25, 2016 at 08:35:39PM +0200, Holger Freyther wrote:
> 
> > On 25 Apr 2016, at 12:51, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> > 
> >> 
> > 
> > There is, obviously, an explicit NULL on the sysmocom/iu branch, where no LLME
> > is applicable.
> > 
> > openbsc/openbsc/src/gprs/gprs_gmm.c:2462:		rc = gsm0408_rcv_gmm(mmctx, msg, NULL);
> > 
> 
> when looking at the patch I thought you would be on master.

IIUC the coverity build uses the iu branches?

But right, I submitted the patch against master, while on the iu branches
I would normally just commit. So, a mixup from my side, sorry!

I'm still glad you found this issue; I do in general highly esteem your
reviews, pretty much always of pinnacle quality in an amazingly short
time. Kudos!

> So yes, for your Iu branch add the NULL check, once we merge to master we need to see if there is valuable information inside the llme that we need to store somewhere else/or just log it.

My guess is that for Iu subscriptions, there will simply be no LLME, and
there won't be information in an LLME that is NULL ;)
But agreed.

The merge-Iu-to-master review will be ... extreme, probably. Daniel and I
should at some point take a look at refactoring the commit sequence to
group by semantics and iron out trial-and-error commits.

But it won't happen without an A-interface, I guess, so it is quite far
down the line at this point (unless we keep NITB somehow, which would
probably also be a bit of work).

~Neels


-- 
- Neels Hofmeyr <nhofmeyr at sysmocom.de>          http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160428/e68bb05d/attachment.bin>


More information about the OpenBSC mailing list