[PATCH 2/2] SysmoBTS: refactor code to simplify understanding

Neels Hofmeyr nhofmeyr at sysmocom.de
Tue Apr 26 11:19:01 UTC 2016


On Fri, Apr 22, 2016 at 03:35:23PM +0200, Holger Freyther wrote:
> 
> > On 21 Apr 2016, at 18:43, msuraev at sysmocom.de wrote:
> > 
> > From: Max <msuraev at sysmocom.de>
> 
> Hi Max,
> 
> 
> > 
> > Use bool type for boolean values.
> > Move common code out of if.. else.
> 
> is this worth our time?

I like API clarifications, IMHO they are "always" worth their time as they
extend "infinitely" into the future for every user.

I'd even prefer two separate commits though.

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160426/7b94ae8b/attachment.bin>


More information about the OpenBSC mailing list