[PATCH] queue_new(): if calloc fails, abort (CID #57918)

Holger Freyther holger at freyther.de
Fri Apr 22 13:39:20 UTC 2016


> On 18 Apr 2016, at 12:56, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> 
> 
> (BTW, the only reason I didn't OSMO_ASSERT() was that there is no other use of
> OSMO_ASSERT() anywhere else in OpenGGSN.)

the GGSN has not used libosmocore before, so there will be many firsts.

> 
> How should we handle this, I'd prefer not to spend time on that now. Commit the
> patch with `return EOF' instead of abort()ing, as the old code suggests? I
> don't know about that, EOF doesn't seem applicable at all.

return EOF then. For commit messages we used to put "Fixes: CID#1234" at the bottom of the commit message.

kind regards
	holger


More information about the OpenBSC mailing list