[PATCH] compiler warning: unconstify arg passed to OCTET_STRING_noalloc()

Harald Welte laforge at gnumonks.org
Fri Apr 15 19:52:01 UTC 2016


On Thu, Apr 14, 2016 at 04:57:11PM +0200, Neels Hofmeyr wrote:

> All callers of OCTET_STRING_noalloc() pass a non-const pointer, except
> that one above. I just want to unconst that single caller.

I think the other callers should be fixed, rather than aligning the one
correct part of the code.

As indicated, I believe we shouldn't let bad impleentation or API design
by asn1c contaminate our code.  A pointer to input data into an encoding
function should be const.

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list