[PATCH] sua_test_common.c: use global RANAP SSN definition

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Neels Hofmeyr nhofmeyr at sysmocom.de
Wed Apr 13 16:01:22 UTC 2016


The test 'hardcoded' a local define for RANAP SSN as 142, instead use the
proper OSMO_SCCP_SSN_RANAP define from sccp_sap.h
---
 tests/sigtran/sua_test_common.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tests/sigtran/sua_test_common.c b/tests/sigtran/sua_test_common.c
index aed4899..66fade0 100644
--- a/tests/sigtran/sua_test_common.c
+++ b/tests/sigtran/sua_test_common.c
@@ -44,8 +44,6 @@ static void sccp_make_addr_pc_ssn(struct osmo_sccp_addr *addr, uint32_t pc, uint
 	addr->pc = pc;
 }
 
-#define SSN_RANAP 142
-
 struct osmo_prim_hdr *make_conn_req(uint32_t conn_id)
 {
 	struct msgb *msg = msgb_alloc(1024, "conn_req");
@@ -56,8 +54,8 @@ struct osmo_prim_hdr *make_conn_req(uint32_t conn_id)
 			OSMO_SCU_PRIM_N_CONNECT,
 			PRIM_OP_REQUEST, msg);
 	/* Set SSN for calling and called addr */
-	sccp_make_addr_pc_ssn(&prim->u.connect.called_addr, 2, SSN_RANAP);
-	sccp_make_addr_pc_ssn(&prim->u.connect.calling_addr, 1, SSN_RANAP);
+	sccp_make_addr_pc_ssn(&prim->u.connect.called_addr, 2, OSMO_SCCP_SSN_RANAP);
+	sccp_make_addr_pc_ssn(&prim->u.connect.calling_addr, 1, OSMO_SCCP_SSN_RANAP);
 	prim->u.connect.sccp_class = 2;
 	prim->u.connect.conn_id = conn_id;
 
-- 
2.1.4




More information about the OpenBSC mailing list