[PATCH] remove two compiler warnings for unused variables

Harald Welte laforge at gnumonks.org
Tue Apr 12 20:49:47 UTC 2016


Hi Neels,

On Tue, Apr 12, 2016 at 01:17:34PM +0200, Neels Hofmeyr wrote:
> On Tue, Apr 12, 2016 at 12:23:52AM +0200, Harald Welte wrote:
> > Hi Max,
> 
> It was me, not Max :)

Sorry.

> > will just mean that we all forget about having to fix it.
> 
> Maybe instead of numerous unused variables, we should have a single
> #warning then. Every warning hinders my dev cycle. For pretty much every
> compilation, I have to parse/browse the list of warnings, *all* the time.

Please let me know after how many compilatiosn the trade-off woudl trip
towards actually addressing those warnings in fixing the related code.

> Even a #warning would stare me in the face for every build. There are a
> couple of those already. 

Well, if everyone every so often would address one of them, it wouldn't
be so bad :)

-- 
- Harald Welte <laforge at gnumonks.org>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)



More information about the OpenBSC mailing list