iuh: Coverity build breakage because of old sctp

Holger Freyther holger at freyther.de
Thu Apr 7 08:40:19 UTC 2016


> On 07 Apr 2016, at 01:12, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> 
> On Wed, Apr 06, 2016 at 09:26:57PM +0200, Holger Freyther wrote:
>> Hi,
>> 
>> sua.c: In function 'rx_inact_tmr_cb':
>> sua.c:288: warning: unused variable 'conn'
>> sua.c: In function 'sua_rx_coref':
>> sua.c:908: warning: unused variable 'cause'
>> sua.c: In function 'sua_rx_codt':
>> sua.c:1059: warning: unused variable 'cur'
>> sua.c: In function 'sua_srv_conn_cb':
>> sua.c:1266: error: 'SCTP_SENDER_DRY_EVENT' undeclared (first use in this function)
>> sua.c:1266: error: (Each undeclared identifier is reported only once
>> sua.c:1266: error: for each function it appears in.)
>> sua.c: In function 'sua_cli_read_cb':
>> sua.c:1451: error: 'SCTP_SENDER_DRY_EVENT' undeclared (first use in this function)
>> 
>> can we make the SCTP_SENDER_DRY_EVENT optional or is a strict requirement? If it is strict then maybe we can check for this in autoconf?
> 
> It's completely unnecessary, I only added logging for it.  Before, it printed a
> notification for "32777", and we surely want to know what that's supposed to
> mean.
> 
> We could add a conditional define like
> 
> 	#ifndef SCTP_SENDER_DRY_EVENT
> 	#define SCTP_SENDER_DRY_EVENT ((1<<15)+9)
> 	#endif

besides on FreeBSD it is

#define SCTP_SENDER_DRY_EVENT                   0x000a

but both define it so please cover the case in a #ifdef.
thanks




More information about the OpenBSC mailing list