[PATCH 1/3] gtp.c: improve an error log.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Freyther holger at freyther.de
Mon Oct 12 07:22:53 UTC 2015


> On 12 Oct 2015, at 02:54, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> 
> diff --git a/gtp/gtp.c b/gtp/gtp.c
> index cfce244..90e0326 100644
> --- a/gtp/gtp.c
> +++ b/gtp/gtp.c
> @@ -741,7 +741,7 @@ int gtp_new(struct gsn_t **gsn, char *statedir, struct in_addr *listen,
> 		(*gsn)->err_socket++;
> 		LOGP(DLGTP, LOGL_ERROR,
> 			"bind(fd0=%d, addr=%lx, len=%d) failed: Error = %s\n",
> -			(*gsn)->fd0, (unsigned long)&addr, sizeof(addr),
> +			(*gsn)->fd0, *((unsigned long*)&addr), sizeof(addr),

did you run into this?  At first I wanted to say then use osmo_hexdump but
as this is an in_addr.. a user wants to see the IP addr and the port number
that could not be bound to. Could you improve this?

holger




More information about the OpenBSC mailing list