[libosmocore PATCH 1/5] abis_nm: Added the new tlv_definition abis_nm_osmo_att_tlvdef in the abis header

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Tue May 20 06:45:35 UTC 2014


On Tue, May 20, 2014 at 07:34:16AM +0200, Alvaro Neira Ayuso wrote:

Hi,

in the subject you are using past tense ("Added") in general one
will use the imperative/present tense. A search points me to this
file in the git sources:

http://git.kernel.org/cgit/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD

"
Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour.  Try to make sure your explanation can be understood
without external resources. Instead of giving a URL to a mailing list
archive, summarize the relevant points of the discussion.
"

I will re-write the subject.

cheers
	holger




More information about the OpenBSC mailing list