Patch: handover check for E1 based BTS

[Sipos Csaba]

The function that checks for HO compatibility is wrong for quite some
time. Even for E1 based BTSs the function requires RTP proxy to be
enabled. The following patch is fixing this, by changing the condition
so RTP proxy is only required, when the BTS is an IP based unit:

diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index 6acf0c6..fbf28ec 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c

@@ -1427,8 +1427,9 @@ DEFUN(cfg_net_handover, cfg_net_handover_cmd,
 {
        int enable = atoi(argv[0]);
        struct gsm_network *gsmnet = gsmnet_from_vty(vty);
+       struct gsm_bts *bts = vty->index;

-       if (enable && ipacc_rtp_direct) {
+       if (enable && ((is_ipaccess_bts(bts)) && ipacc_rtp_direct)) {
                vty_out(vty, "%% Cannot enable handover unless RTP Proxy mode "
                        "is enabled by using the -P command line option%s",
                        VTY_NEWLINE);


The patch is tested with Nokia Insite.

I hope someone can commit this to the master branch.

Regards,
Csaba