This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Wed, Jul 16, 2014 at 07:04:31PM +0200, Daniel Willmann wrote:
> void gprs_rlcmac_pdch::rcv_resource_request(Packet_Resource_Request_t *request, uint32_t fn)
> {
> - struct gprs_rlcmac_tbf *tbf;
> + struct gprs_rlcmac_ul_tbf *ul_tbf;
> + struct gprs_rlcmac_dl_tbf *dl_tbf;
Limit the dl_tbf (and ul_tbf) in scope. The dl_tbf one part of the code
is dealing with is not the one the other is using. We should not accidently
leak a tbf into another scope just because this method is huge.
In general cppcheck's style warnings complain about this kind of thing