[PATCH 6/9] mgcp: Set output_enabled flags based on the MGCP mode

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Wed Jan 8 09:45:12 UTC 2014


On Tue, Jan 07, 2014 at 12:07:48PM +0100, Jacob Erlbeck wrote:

Good Morning,

> diff --git a/openbsc/tests/mgcp/mgcp_test.ok b/openbsc/tests/mgcp/mgcp_test.ok
> index 43a7402..6db7226 100644
> --- a/openbsc/tests/mgcp/mgcp_test.ok
> +++ b/openbsc/tests/mgcp/mgcp_test.ok


In the test case you force the output_enabled variable to 0. Now that
the state is set based on the connection mode I think it is dangerous
to set the state inside the testcase. mgcp_free_endpoint should reset
it and we should rely and test that.

What do you think?





More information about the OpenBSC mailing list