This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Holger Hans Peter Freyther holger at freyther.deOn Wed, Jan 15, 2014 at 04:23:23PM +0100, Andreas Eversberg wrote: > in both functions is a check for conn and lchan not beeing NULL: > > if (trans->conn && trans->conn->lchan) > setup.lchan_type = trans->conn->lchan->type; > > the functions are called by gsm0408_rcv_cc(). from there i can see that > trans->conn->lchan is always set, so the if-condition above is not required. > Exactly. Coverity points out that first you check if (trans->conn), there is no return and later we _unconditionally_ do "trans->conn->bts". a.) Coverity is right and there are conditions it can crash b.) The if (trans->conn) is not needed. Could you please elaborate which of the two is the case here? holger