[PATCH 2/8] agch: Added queue operation logging (DEBUG)

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Alexander Chemeris alexander.chemeris at gmail.com
Sat Feb 22 08:10:11 UTC 2014


On Sat, Feb 22, 2014 at 11:58 AM, Holger Hans Peter Freyther
<holger at freyther.de> wrote:
>
> On Sat, Feb 22, 2014 at 12:36:03AM +0100, Jacob Erlbeck wrote:
> > This adds debug logging to the AGCH queue operations.
>
> I'm a bit reluctant to add more logging. In the past I have thrown out
> a lot of log messages. Do we need these messages? What kind of issues
> can we diagnose that we can't get through observing statistics and/or the
> A-link to the BSC/NITB?

At DEBUG level this should not harm much.

Benefits of logs that it's easier to correlate with other events
logged at the same place. And that you could use them retrospectively
(given you have the proper debugging level enabled). On most machines
overhead of running full logging is minimal, while it makes actual
debugging much easier.

If you worry about performance drop just because of the check, I think
it make sense to have a special macro for DEBUG level, which will turn
into a NOP in case of NDEBUG.

What do you think?

-- 
Regards,
Alexander Chemeris.
CEO, Fairwaves LLC / ООО УмРадио
http://fairwaves.ru




More information about the OpenBSC mailing list