[PATCH 13/33] l1sap: Add a warning about assuming BS_AG_BLKS_RES=1

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Harald Welte laforge at gnumonks.org
Wed Aug 27 21:54:32 UTC 2014


This is a regression of the code compared to the existing
sysmoBTS code, where the L1 tells us whether its AGCH or
PCH.  However, it was not used even in the old code, so
we can afford to simply put a #warning here.
---
 src/common/l1sap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index da4cc48..12be383 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -112,6 +112,7 @@ static int l1sap_ph_rts_ind(struct gsm_bts_trx *trx,
 			memcpy(p, fill_frame, GSM_MACBLOCK_LEN);
 	} else if (L1SAP_IS_CHAN_AGCH_PCH(chan_nr)) {
 		p = msgb_put(msg, GSM_MACBLOCK_LEN);
+#warning "TODO: Yet another assumption that BS_AG_BLKS_RES=1"
 		/* if CCCH block is 0, it is AGCH */
 		rc = bts_ccch_copy_msg(trx->bts, p, &g_time,
 			(L1SAP_FN2CCCHBLOCK(fn) < 1));
-- 
2.1.0





More information about the OpenBSC mailing list