[PATCH 1/4] Added new auth policy black-list.

[Holger Hans Peter Freyther]

On Wed, Sep 18, 2013 at 09:01:09PM +0400, Ivan Kluchnikov wrote:

> > On second thought I wonder about the semantic of this patch. E.g.
> > if I run an accept-all network.. and then switch to a closed
> > policy. The authorized field will still be 0. But with this change
> > I can not easily change.
> 
> For auth policy clarification:
> accept-all =  accept MS with authorized = 1 and 0,  for all new
> subscribers set authorized = 0
> closed =  accept MS with authorized = 1, MS with authorized = 0 and
> all new subscribers should be rejected
> black-list =  accept MS with authorized = 1, MS with authorized = 0
> should be rejected,  for all new subscribers set authorized = 1
> 
> You can see, that "black-list" is like "closed", but in black-list
> mode we set authorized = 1 for all new subscribers.
> So the idea was to save meaning of authorized parameter, accept with
> authorized = 1 and reject with authorized = 0.


My point was that. Currently I can do:

1.) accept-all policy... new subscribers will be allowed to register
send/sms/added to the database but their actually authorized=1

2.) I decide to change to closed. All previous subscribers are not
allowed in anymore.

This means I can change policy without updating the database. I think
it would be nice for the black-list too.

> 
> What's the problem to use net inside the db code?
> Moreover, net is used in db_create_subscriber() function.

It is a layering violation. The DB code should know little about
the gsm_network. It should just save and restore records. We should
assign subscriber->net outside of the code.