[PATCH 2/6] vty: Add test to check vty node hierarchy and related commands

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Jacob Erlbeck jerlbeck at sysmocom.de
Mon Sep 2 07:48:27 UTC 2013


On 08/31/2013 03:41 PM, Holger Hans Peter Freyther wrote:
> On Fri, Aug 30, 2013 at 06:33:59PM +0200, Jacob Erlbeck wrote:
>
>> -class TestVTYNITB(TestVTYBase):
>> +
>> +class TestVTYGenericBTS(TestVTYBase):
> Why BTS? NITB/BSC mostly define the BSC functionality. I would
> call it TestVTYGenericBSC. I can change it locally if you do
> not object.

Oops, that was a typo. Thanks for finding and fixing.
>> +    def notIgnoredTest(self):
>> +        sys.stderr.write('Going to ignore the next assertion(s) due to known bugs\n')
>> +        return False
> I am still a bit puzzled here. Is this statement still accurate?
> Specially because this is used with a if/else statement.
>
That's just an intermediate to keep the tests running until refactoring
is done. So I didn't put much effort into this. We could even remove it
with PATCH 5/6 of this set.




More information about the OpenBSC mailing list