[PATCH 1/8] mgcp: Rename for_each_line to for_each_non_empty_line

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Sat Nov 30 18:08:04 UTC 2013


On Fri, Nov 29, 2013 at 01:43:43PM +0100, Jacob Erlbeck wrote:
> The implementation of for_each_line is based on strtok() and skips
> any sequence of CR and LF. Thus empty lines are never detected. There
> exists code which tests for an empty line to detect the beginning of
> the SDP part which is dead code currently (the parser works
> nevertheless due to other reasons). So the semantics of this macro
> have been misunderstood at least once.
> 
> This patch renames the macro to reflect the semantics more precisely.

Do you want to remove the "case '\0':" lines (just to add them in later
commits again)?





More information about the OpenBSC mailing list