Coverity issues in lapd_core/gsm mncc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg andreas at eversberg.eu
Sat Jul 6 08:19:52 UTC 2013


Holger Hans Peter Freyther wrote:
> src/input/misdn.c
> static int _mi_e1_line_update(struct e1inp_line *line)
>
> this function is not closing the 'sk' filedescriptor which is of type
>   sk = socket(PF_ISDN, SOCK_RAW, ISDN_P_BASE);
>
> do we need to keep this one open or is this is a bug? Pablo and me
> currently do not have a mISDN setup, so we can not easily answer this
> question right now.
>   
hi holger,

the socket is only used to get information about isdn interfaces, so it
shall be closed, if not used anymore. your patch looks good to me.

best regards,

andreas





More information about the OpenBSC mailing list