[PATCH] ipaccess: relax default behaviour on errors coming from signalling layer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Tue Oct 16 09:24:08 UTC 2012


This patch relaxes the behaviour on error coming from the signalling
layer. This is probably too strict for recoverable errors.

Thanks to Lennart Müller <mueller.lennart at googlemail.com> for the report.
---
 src/input/ipaccess.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c
index d63e796..4f81c43 100644
--- a/src/input/ipaccess.c
+++ b/src/input/ipaccess.c
@@ -450,10 +450,13 @@ static int handle_ts1_read(struct osmo_fd *bfd)
 		goto err_msg;
 	}
 	if (e1i_ts->line->ops->sign_link(msg) < 0) {
+		/* Don't close the signalling link if the upper layers report
+		 * an error, that's too strict.
+		 */
 		LOGP(DLINP, LOGL_ERROR, "Bad signalling message,"
 			"sign_link returned error\n");
 		ret = -EINVAL;
-		goto err;
+		msgb_free(msg);
 	}
 
 	return 0;
-- 
1.7.10.4


--LZvS9be/3tNcYl/X--




More information about the OpenBSC mailing list