[PATCH 05/11] ipaccess: more robust error handling in the accept patch

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Holger Hans Peter Freyther holger at freyther.de
Thu Aug 23 07:28:54 UTC 2012


On Wed, Aug 22, 2012 at 05:04:47PM +0200, pablo at gnumonks.org wrote:
> +err:
> +	close(bfd->fd);
> +	e1inp_line_put(line);
> +	return ret;
>  }

one more thing. The code in ipaccess_drop appears to set bfd->fd = -1. Do
we need that? You certainly don't have to do this in the current patchset
but it would be nice if we at least know if we should (re)initialize to -1
or not.


holger




More information about the OpenBSC mailing list