This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Pablo Neira Ayuso pablo at gnumonks.orgOn Fri, Sep 09, 2011 at 03:51:08PM +0200, Daniel Willmann wrote: > Pablo Neira Ayuso <pablo at gnumonks.org> wrote: > > >On Fri, Sep 09, 2011 at 03:05:26AM +0200, pablo at gnumonks.org wrote: > >> From: Pablo Neira Ayuso <pablo at gnumonks.org> > >> > >> Hi, > >> > >> These patchset contains the port of libctrl to use the IPA > >> infrastructure available in libosmo-abis. > >> > >> I've also made one small cleanup to bail out in case that > >> we cannot bind to the telnet port. Another patch follows up > >> to avoid disabling nagle (to avoid problems with TCP > >> segmentation, we still have to support this appropriately), > >> I noticed this while doing the port work. > > Thanks Pablo, I'll take a look at them tonight. Not sure about the nodelay issue, I think it was an issue of doing it similar to other places in the code, but I'll check. The LOGP call in the code to disable nagle was using DNAT logging level, so I guess it's a leftover. I still think we have to remove this option until we fully support TCP segmentation (I'm working on some patches for that, they will come but until that not sure what's the benefit of disabling nagle anyway). Wait for your comments!