[PATCH 0/5] pablo/ctrl-updates related patches

Pablo Neira Ayuso pablo at gnumonks.org
Fri Sep 16 01:17:49 CEST 2011


On Thu, Sep 15, 2011 at 04:04:48PM +0200, Daniel Willmann wrote:
> Hello Pablo,
> 
> attached are patches against the current pablo/ctrl-updates branch that
> fix the compile issues. It needs the closed callback in libosmo-abis to
> work. As long as the bsc_msc_connection is still using write_queues I
> have added the old ctrl_cmd_send function again (under a different name)
> So we can still send commands over that connection.
> I've tested the communication/timeout/closed_cb handling and nothing
> problematic showed up.

Thanks Daniel, I'll rebase the pablo/ctrl-updates change with these
patches and resubmit.

> Having two send commands is unfortunate, but I guess it's okay for the
> time being. I'm guessing that the other connections will be switching to
> libosmo-abis as well in the foreseeable future and then this issue will
> resolve itself.

Indeed, make sense to me for the time being.

I'll look for more candidates that can be ported to the generic IPA
infrastructure. It can be interesting to see if they have any other
specific need, I think we're still in time to make not-very-painful
API/ABI changes.




More information about the OpenBSC mailing list