[PATCH 0/5] libosmocore: namespace pollution fixes (1/*) 2nd try

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Pablo Neira Ayuso pablo at gnumonks.org
Sat May 7 11:33:05 UTC 2011


On 06/05/11 13:39, Harald Welte wrote:
> Ok, I have checked the 'nm' output of current libosmocore.a of that
> branch, and the only functions without an osmo_ prefix are:
> 
> msgb_* (which is ok)
> bitvec_* (which is ok, too)
> log_* (i guess ok, too)
> gsmtap_* (which is ok)
> talloc_* (which is ok)
> rate_ctr_* (which is ok)
> chantype_rsl2gsmtap (ok)
> get_string_value/get_value_string (ok)
> 
> However, there are seome others. Pablo, can you please also prefix those:
> 	bcd2char, char2bcd 
> 	crc16
> 	generate_backtrace
> 	plugin_load_all
> 
> Once this has been resolved, I will merge your branch.  

I have also fixed this.

You can find the patches in the mailing list and all the changes in
pablo/namespace branch.

> We should also make a first official libosmocore release soon, and from
> now on make sure we keep binary (ABI) compatibility within the autotools
> library versioning rules.  As a second step, we can try to get the
> library included in Debian and other distros.

I'll make a patch to make libosmocore use:

* EXPORT_SYMBOL
* a .map file with exported symbols and versions
* use libversion (we only have to use revisions field, current and aging
field should never be used)

I'll document the way of working, of course.

> Finally, we have one remaining issue: msg_entry_parse
> 
> I think msg / msgb are a bit too close and they don't do anything
> related.  Maybe we can come up with a different name, possibly including
> the osmo_ prefix?  Holger?

I have used osmo_config_list and osmo_config_entry for this, as
suggested by Holger.




More information about the OpenBSC mailing list